Emails: Migrate to SettingsSection and CRUD components
What does this MR do and why?
Migrates Email page to use SettingsSection and CRUD
- Migrates also button
Remove
to tertiary variant to add consistency with other implementations
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Related to #452231 (closed)
Merge request reports
Activity
changed milestone to %17.3
assigned to @seggenberger
added devopsmanage groupux paper cuts sectioncore platform labels
added pipelinetier-1 label
removed pipelinetier-1 label
1 Warning This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/views/profiles/emails/index.html.haml
- = render Pajamas::ButtonComponent.new(size: :small, button_options: { class: "js-toggle-button js-toggle-content", data: { testid: 'toggle-email-address-field' } }) do + toggle_options: { data: { testid: 'toggle-email-address-field' } }) do |c| + = f.text_field :email, class: 'form-control gl-form-input gl-form-input-xl', data: { testid: 'email-address-field' } + = f.submit s_('Profiles|Add email address'), data: { testid: 'add-email-address-button' }, pajamas_button: true - = f.text_field :email, class: 'form-control gl-form-input gl-form-input-xl', data: { testid: 'email-address-field' } - = f.submit s_('Profiles|Add email address'), data: { testid: 'add-email-address-button' }, pajamas_button: true + button_options: { class: 'has-tooltip', title: _('Remove'), data: { confirm: _('Are you sure?'), confirm_btn_variant: 'danger', testid: 'delete-email-link' } }) - = link_button_to nil, profile_email_path(email), data: { confirm: _('Are you sure?'), confirm_btn_variant: 'danger', testid: 'delete-email-link'}, method: :delete, size: :small, icon: 'remove', 'aria-label': _('Remove')
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer backend @carlad-gl
(UTC+2, same timezone as author)
@eurie
(UTC-4, 6 hours behind author)
frontend @jrushford
(UTC+2, same timezone as author)
@sheldonled
(UTC+1, 1 hour behind author)
groupimport and integrate (frontend) @justin_ho
(UTC+7, 5 hours ahead of author)
Maintainer review is optional for groupimport and integrate (frontend) UX @clavimoniere
(UTC-4, 6 hours behind author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@seggenberger
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added UX UX Paper Cuts maintenancerefactor sectiondev typemaintenance labels and removed sectioncore platform label
- Resolved by Sheldon Led
requested review from @annabeldunstone and @jrushford
requested review from @sheldonled and removed review request for @jrushford
added pipeline:mr-approved label
added pipelinetier-2 label
removed review request for @annabeldunstone