Skip to content
Snippets Groups Projects

Add several backend filters to the Vue version of the merge request list

All threads resolved!

What does this MR do and why?

This adds several backend filters for the upcoming Vue merge request list:

* :approver, filter by possible approver of a merge request

  • :approved_by, filter by someone who approved a merge request
  • :my_reaction_emoji, filter by emoji you've applied
  • :merged_by, filter by merger of a merge request
  • :release, filter by release tag

The frontend doesn't use these (yet), but for extra credit you could confirm by merging these MRs:

Then enable the vue_merge_request_list feature flag and check the merge requests search bar of a project.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to:

Edited by Gary Holtz

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Gary Holtz changed the description

    changed the description

  • Gary Holtz marked this merge request as ready

    marked this merge request as ready

  • Gary Holtz added 3 commits

    added 3 commits

    • a0fdba8b - Add backend support for multiple Vue list filters
    • bc33c237 - Fixing spec
    • 6799788b - Refactor out test to EE

    Compare with previous version

  • Gary Holtz requested review from @lwanko

    requested review from @lwanko

  • Gary Holtz changed title from Add several filter to the Vue version of the merge request list to Add several backend filters to the Vue version of the merge request list

    changed title from Add several filter to the Vue version of the merge request list to Add several backend filters to the Vue version of the merge request list

  • mentioned in issue #442920 (closed)

  • mentioned in issue #442914 (closed)

  • mentioned in issue #442919 (closed)

  • mentioned in issue #442916 (closed)

  • mentioned in issue #442915 (closed)

  • Lukas Wanko
  • Lukas Wanko
  • Lukas Wanko
  • Lukas Wanko
  • Lukas Wanko
  • Lukas Wanko
  • Gary Holtz added 1 commit

    added 1 commit

    • ad7f21d5 - Quick refactor and spec change

    Compare with previous version

  • Lukas Wanko
  • Gary Holtz changed the description

    changed the description

  • Gary Holtz requested review from @lwanko

    requested review from @lwanko

  • Lukas Wanko approved this merge request

    approved this merge request

  • Lukas Wanko requested review from @minac

    requested review from @minac

  • Lukas Wanko removed review request for @lwanko

    removed review request for @lwanko

  • Mehmet Emin INAC
  • Mehmet Emin INAC removed review request for @minac

    removed review request for @minac

  • Gary Holtz added 1 commit

    added 1 commit

    • ba799928 - Adding negated release tag, changing name

    Compare with previous version

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 99707851

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
    | Plan        | 70     | 0      | 0       | 0     | 70    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Create      | 127    | 0      | 12      | 0     | 139   | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
    | Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Package     | 16     | 0      | 15      | 0     | 31    | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Secure      | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 378    | 0      | 31      | 0     | 409   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for 99707851

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Create | 415    | 0      | 51      | 0     | 466   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 415    | 0      | 51      | 0     | 466   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
  • Gary Holtz added 1707 commits

    added 1707 commits

    Compare with previous version

    • Resolved by Nikhil George

      Dependency change review report

      Please wait to merge until below tasks are completed by @gitlab-com/gl-security/appsec

      • Review metadata report and resolve this thread. Review guidelines are at handbook page
      Click to view metadata analysis report

      Modified Dependency: google-protobuf (3.25.4) Location: Gemfile.lock Version diffs

      Checks passed:5/6 :warning:
      • :information_source:️ Latest version: 4.28.0.rc.1 released on: 2024-07-31. URL: https://rubygems.org/gems/google-protobuf
      • :warning: Latest version is not in use.
      • :white_check_mark: Total downloads: 276275648
      • :white_check_mark: Reverse dependencies: 190
      • :white_check_mark: Total number of releases: 1114
      • :white_check_mark: Latest version age (months): 0
      • :white_check_mark: Source project in Github not archived.
      • :information_source:️ Maintainer emails are private. Email domain check skipped.

      :warning: This automation is under testing, please leave your feedback in the issue.

  • Gary Holtz added 1 commit

    added 1 commit

    • fd7ece0c - Fixing Gemfile.lock git mistake

    Compare with previous version

  • Gary Holtz added 1 commit

    added 1 commit

    • 74cc54e7 - GraphQL docs generation is broken again

    Compare with previous version

  • Gary Holtz
  • Gary Holtz requested review from @minac

    requested review from @minac

  • Gary Holtz added 1 commit

    added 1 commit

    Compare with previous version

  • Gary Holtz added 1 commit

    added 1 commit

    Compare with previous version

  • added backend-weight4 label and removed backend-weight1 label

  • Gary Holtz changed the description

    changed the description

  • Gary Holtz added 2 commits

    added 2 commits

    Compare with previous version

  • Author Maintainer

    I'm removing the approver attribute because the EE/GraphQL structure in GitLab is a nightmare and will need it's own MR.

  • Gary Holtz added 1 commit

    added 1 commit

    Compare with previous version

  • Gary Holtz added 1 commit

    added 1 commit

    Compare with previous version

  • Mehmet Emin INAC
  • Mehmet Emin INAC
  • Mehmet Emin INAC
  • Mehmet Emin INAC removed review request for @minac

    removed review request for @minac

  • Gary Holtz added 2 commits

    added 2 commits

    • 2c2e53ac - Fixing things based on review
    • 99707851 - Fixing things based on review

    Compare with previous version

  • Gary Holtz requested review from @minac

    requested review from @minac

  • Mehmet Emin INAC approved this merge request

    approved this merge request

  • Mehmet Emin INAC resolved all threads

    resolved all threads

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Mehmet Emin INAC enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Pipeline failure looks unrelated, I'm creating a new pipeline.

  • mentioned in commit d767b3b5

  • added workflowstaging label and removed workflowcanary label

  • Gary Holtz mentioned in merge request !161987 (merged)

    mentioned in merge request !161987 (merged)

  • Please register or sign in to reply
    Loading