Add several backend filters to the Vue version of the merge request list
What does this MR do and why?
This adds several backend filters for the upcoming Vue merge request list:
* :approver, filter by possible approver of a merge request
- :approved_by, filter by someone who approved a merge request
- :my_reaction_emoji, filter by emoji you've applied
- :merged_by, filter by merger of a merge request
- :release, filter by release tag
The frontend doesn't use these (yet), but for extra credit you could confirm by merging these MRs:
- Add My Reaction filter to Vue merge request lis... (!159807 - merged)
- Add merged-by filter to Vue merge request list app (!159808 - merged)
- Add approved-by filter to Vue merge request lis... (!160005 - merged)
Then enable the vue_merge_request_list
feature flag and check the merge requests search bar of a project.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to:
- Add my-reaction filter to Vue merge request lis... (#442920 - closed)
- Add release filter to Vue merge request list app (#442919 - closed)
- Add approved-by filter to Vue merge request lis... (#442916 - closed)
- Add approver filter to Vue merge request list app (#442915 - closed)
- Add merged-by filter to Vue merge request list app (#442914 - closed)
Merge request reports
Activity
changed milestone to %17.3
assigned to @garyh
added 1 commit
- f664a199 - Add backend support for multiple Vue list filters
- A deleted user
added documentation label
6 Warnings This MR has a Changelog commit for EE, but no code changes in ee/
. Consider removing theEE: true
trailer from your commits.b72d64ec: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 36e74bec: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 13af07b4: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 3174a857: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ef923ef7: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @zmartins
(UTC+2, 7 hours ahead of author)
@pedropombeiro
(UTC+2, 7 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
added 1 commit
- 5b008acb - Pointless docs change because the graphql docs check is broken
added 22 commits
-
5b008acb...5a4fecc7 - 21 commits from branch
master
- 95cd4985 - Add backend support for multiple Vue list filters
-
5b008acb...5a4fecc7 - 21 commits from branch
added 1 commit
- 8caf8b34 - Add backend support for multiple Vue list filters
added 1 commit
- 140e7119 - Add backend support for multiple Vue list filters
- Resolved by Lukas Wanko
- Resolved by Mehmet Emin INAC
Hi @lwanko! Could you please do the initial review for this?
requested review from @lwanko
mentioned in issue #442920 (closed)
mentioned in issue #442914 (closed)
mentioned in issue #442919 (closed)
mentioned in issue #442916 (closed)
mentioned in issue #442915 (closed)
- Resolved by Lukas Wanko
- Resolved by Lukas Wanko
- Resolved by Lukas Wanko
- Resolved by Lukas Wanko
- Resolved by Lukas Wanko
- Resolved by Lukas Wanko
- Resolved by Lukas Wanko
requested review from @lwanko
added pipeline:mr-approved label
added pipelinetier-2 label
requested review from @minac
removed review request for @lwanko
- Resolved by Mehmet Emin INAC
- Resolved by Gary Holtz
- Resolved by Mehmet Emin INAC
- Resolved by Mehmet Emin INAC
removed review request for @minac
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 99707851expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Plan | 70 | 0 | 0 | 0 | 70 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 16 | 0 | 15 | 0 | 31 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 378 | 0 | 31 | 0 | 409 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 99707851expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 415 | 0 | 51 | 0 | 466 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 415 | 0 | 51 | 0 | 466 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
added 1707 commits
-
ba799928...8cc1eff9 - 1701 commits from branch
master
- 7b385336 - Add backend support for multiple Vue list filters
- ef923ef7 - Fixing spec
- 7b4cb3a1 - Refactor out test to EE
- a75d6cf2 - Quick refactor and spec change
- 3174a857 - Adding negated release tag, changing name
- 13af07b4 - Moving things to EE and updating resolvers
Toggle commit list-
ba799928...8cc1eff9 - 1701 commits from branch
- Resolved by Nikhil George
Dependency change review report
Please wait to merge until below tasks are completed by @gitlab-com/gl-security/appsec
- Review metadata report and resolve this thread. Review guidelines are at handbook page
Click to view metadata analysis report
Modified Dependency: google-protobuf (3.25.4) Location:
Gemfile.lock
Version diffsChecks passed:5/6
-
️ Latest version: 4.28.0.rc.1 released on: 2024-07-31. URL: https://rubygems.org/gems/google-protobuf -
Latest version is not in use. -
Total downloads: 276275648 -
Reverse dependencies: 190 -
Total number of releases: 1114 -
Latest version age (months): 0 -
Source project in Github not archived. -
️ Maintainer emails are private. Email domain check skipped.
This automation is under testing, please leave your feedback in the issue.
- Resolved by Mehmet Emin INAC
- Resolved by Mehmet Emin INAC
@minac Could you give this another look?
requested review from @minac
added backend-weight4 label and removed backend-weight1 label
added 2 commits
- Resolved by Mehmet Emin INAC
- Resolved by Mehmet Emin INAC
- Resolved by Mehmet Emin INAC
- Resolved by Mehmet Emin INAC
- Resolved by Mehmet Emin INAC
- Resolved by Mehmet Emin INAC
removed review request for @minac
added 2 commits
requested review from @minac
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit d767b3b5
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3241 (merged)
mentioned in merge request !161987 (merged)