Skip to content

Do not show 'automatically removed' for manually removed labels

Felipe Artur requested to merge issue_12952 into master

What does this MR do?

Prevent showing 'automatically removed' for manually removed scoped labels.

Edge case:
When adding and removing multiple labels and one of the labels removal is not automatic we show the regular remove message.

This is the best solution i could think to fix the problem without a need to refactor LabelNote, ScopedLabelSet or change the system notes messages. I hope it is acceptable.

closes #12952 (closed)

Screenshots

scoped_labels_system_notes

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Felipe Artur

Merge request reports