Expand CI variables before glob separation
What does this MR do and why?
Expand CI variables before glob separation
We sort globs into three types depending on their content.
Doing that before expanding variables can lead to them
being sorted incorrectly. In consequence they are also
applied incorrectly, leading to missing some matches
when variables contain /
or **
.
Fixes #386595 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- Set up new project
- Add directory and file
folder/file
- Add this CI configuration:
variables: dir: "folder" file: "file" full_path: "folder/file" a: rules: - exists: - $dir/$file script: - echo hi b: rules: - exists: - $full_path script: - echo hi
- Observe both jobs running with this branch, but only job a running with latest default
Merge request reports
Activity
assigned to @manuelgrabowski
added pipelinetier-1 label
added Support Team Contributions label
- A deleted user
added backend label
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@manuelgrabowski
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @bhrai
(UTC+2)
@dskim_gitlab
(UTC+10)
~"Verify" Reviewer review is optional for ~"Verify" @ayufan
(UTC+2)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded bugfunctional label
added typebug label
added grouppipeline authoring label
added Category:Pipeline Composition devopsverify sectionci labels
mentioned in issue #386595 (closed)
changed milestone to %17.3
added feature flagskipped label
requested review from @syasonik
mentioned in issue #417251 (closed)
mentioned in issue #411344 (closed)
- Resolved by Allison Browne
Thanks @manuelgrabowski! LGTM!
Passing to @grzesiek for backend maintainer &
verify
review.
requested review from @grzesiek
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 2027968dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Plan | 70 | 0 | 0 | 0 | 70 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Verify | 88 | 0 | 4 | 0 | 92 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Package | 16 | 0 | 15 | 0 | 31 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 422 | 0 | 33 | 0 | 455 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 2027968dexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Verify | 102 | 0 | 30 | 4 | 132 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 102 | 0 | 30 | 4 | 132 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
requested review from @rutgerwessels
removed review request for @grzesiek
removed review request for @rutgerwessels
requested review from @allison.browne
- Resolved by Allison Browne
- Resolved by Allison Browne
- Resolved by Allison Browne
@manuelgrabowski, I left two suggestions. What do you think?
added 2774 commits
-
f0aece9c...bd509efa - 2772 commits from branch
master
- ad54e635 - Expand CI variables before glob separation
- ed9287e7 - Guard early variable expansion behind FF
-
f0aece9c...bd509efa - 2772 commits from branch
reset approvals from @rutgerwessels by pushing to the branch
- A deleted user
added feature flag feature flagexists labels and removed feature flagskipped label
requested review from @allison.browne
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
Hello again @allison.browne!
I started another pipeline earlier, that way it should still satisfy thepipeline is recent enough
checklist item during most of your workday.@manuelgrabowski, it looks like it merged this time. Nice work!
started a merge train