Update achievements
What does this MR do and why?
Update achievements
- Make icons larger
- Move counter badges
- Remove outline
- Remove max number (limit is no longer needed)
> 1
)
Screenshots or screen recordings (pretend these are different achievements with counters Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Look at user profile achievements
- I didn't have multiple achievements of the same type locally, so removed
v-if="showCountBadge(userAchievement.count)"
on thebadge
inapp/assets/javascripts/profile/components/user_achievements.vue
Links
Merge request reports
Activity
changed milestone to %17.3
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
mentioned in issue Taucher2003/reporting#632 (closed)
added pipelinetier-1 label
1 Warning This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/profile/components/user_achievements.vue
- data-testid="user-achievement" - data-testid="achievement-description" + data-testid="user-achievement" + data-testid="achievement-description"
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @jrushford
(UTC+2, 2 hours ahead of author)
@anna_vovchenko
(UTC+3, 3 hours ahead of author)
UX @mnichols1
(UTC-4, 4 hours behind author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Anna Vovchenko
requested review from @jmiocene
removed review request for @jmiocene
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 67ecce4aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 63 | 0 | 6 | 0 | 69 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Govern | 69 | 0 | 0 | 0 | 69 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 1 | 0 | 0 | 0 | 1 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 369 | 0 | 33 | 0 | 402 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 67ecce4aexpand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | Data Stores | 47 | 0 | 10 | 0 | 57 | ✅ | | Govern | 109 | 0 | 8 | 2 | 117 | ✅ | | Create | 425 | 0 | 51 | 99 | 476 | ✅ | | Manage | 30 | 0 | 15 | 2 | 45 | ✅ | | Verify | 51 | 0 | 15 | 2 | 66 | ✅ | | Systems | 7 | 0 | 0 | 0 | 7 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Plan | 82 | 0 | 17 | 0 | 99 | ✅ | | Package | 31 | 0 | 14 | 6 | 45 | ✅ | | Fulfillment | 4 | 0 | 7 | 0 | 11 | ✅ | | Secure | 4 | 0 | 2 | 0 | 6 | ✅ | | Configure | 1 | 0 | 3 | 0 | 4 | ✅ | | Analytics | 3 | 0 | 0 | 0 | 3 | ✅ | | Ai-powered | 1 | 0 | 2 | 0 | 3 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 814 | 0 | 162 | 111 | 976 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
requested review from @leetickett-gitlab