Skip to content

Generic alertsettings just add button

Simon Knox requested to merge generic-alertsettings-just-add-button into master

What does this MR do?

Alternative approach to https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15733

Render the form in haml, and just the Reset key button and modal in Vue. Tradeoff is the selector is a bit ugly

Screenshots

Screen_Shot_2019-09-02_at_4.29.13_pm

Screen_Shot_2019-09-02_at_4.29.18_pm

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Simon Knox

Merge request reports