Remove padding if sections settings have no border
What does this MR do and why?
Remove additional padding in settings-section-no-bottom
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Go a settings area with at least one instance of .settings-section-no-bottom
(ie http://127.0.0.1:3000/groups/gitlab-org/-/settings/packages_and_registries)
Links
Merge request reports
Activity
changed milestone to %17.3
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
added pipelinetier-1 label
mentioned in merge request !159737 (merged)
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer frontend @rcrespo3
(UTC-4, 4 hours behind author)
@f_caplette
(UTC-4, 4 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
- Resolved by Annabel Dunstone Gray
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you resolve this discussion, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 46962e77expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Verify | 44 | 0 | 3 | 1 | 47 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Govern | 69 | 0 | 0 | 0 | 69 | ✅ | | Plan | 67 | 0 | 2 | 0 | 69 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 373 | 0 | 30 | 1 | 403 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Annabel Dunstone Gray
@ankit.panchal Could you please review this small change?
requested review from @ankit.panchal
added pipelinetier-3 label and removed pipelinetier-2 label
added workflowstaging-canary label