Skip to content

Use atlassian-jwt-ruby gem

Heinrich Lee Yu requested to merge use-atlassian-jwt-gem into master

What does this MR do?

e3f9cc43 introduced the atlassian-jwt gem as part of the jira-ruby dependency update.

This removes our own class that was based on that gem. I did some cosmetic changes to change the order of params and use keyword arguments so I had to change the callers to match the original arguments in the gem.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports

Loading