Integrate Topology Service Gem into GitLab
What does this MR do and why?
Integrating the current version of Topology Service Gem into GitLab
Addressing: #451052 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
In the Rails Console, run
[1] pry(main)> require 'gitlab/cells/topology_service'
=> trueRelated to #451052 (closed)
Merge request reports
Activity
changed milestone to %17.3
assigned to @OmarQunsulGitlab
added pipelinetier-1 label
- Resolved by Ottilia Westerlund
Dependency change review report
Please wait to merge until below tasks are completed by @gitlab-com/gl-security/appsec
- Review metadata report and resolve this thread. Review guidelines are at handbook page
Click to view metadata analysis report
New Dependency: gitlab-topology-service-client (0.1) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:2/5
-
-
-
-
-
-
-
-
New Dependency: activesupport (7.1.3.2) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: ast (2.4.2) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: base64 (0.2.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: bigdecimal (3.1.8) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed: 7/7
-
-
-
-
-
-
-
-
New Dependency: concurrent-ruby (1.2.3) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: connection_pool (2.4.1) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: diff-lcs (1.5.1) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed: 6/6
-
-
-
-
-
-
-
-
New Dependency: drb (2.2.1) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: gitlab-styles (10.1.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:4/5
-
-
-
-
-
-
-
-
New Dependency: google-protobuf (3.25.3) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: googleapis-common-protos-types (1.14.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: grpc (1.63.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: i18n (1.14.5) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed: 6/6
-
-
-
-
-
-
-
-
New Dependency: json (2.7.1) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: minitest (5.22.3) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: mutex_m (0.2.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: parallel (1.24.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: parser (3.3.0.5) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: racc (1.7.3) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: rack (3.0.11) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: rainbow (3.1.1) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: regexp_parser (2.9.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: rexml (3.2.6) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: rspec (3.13.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed: 6/6
-
-
-
-
-
-
-
-
New Dependency: rspec-core (3.13.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed: 6/6
-
-
-
-
-
-
-
-
New Dependency: rspec-expectations (3.13.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: rspec-mocks (3.13.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: rspec-support (3.13.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: rubocop (1.50.2) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: rubocop-ast (1.30.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: rubocop-capybara (2.20.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/7
-
-
-
-
-
-
-
-
New Dependency: rubocop-factory_bot (2.25.1) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/7
-
-
-
-
-
-
-
-
New Dependency: rubocop-graphql (0.19.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: rubocop-performance (1.20.2) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: rubocop-rails (2.23.1) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: rubocop-rspec (2.29.2) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:6/7
-
-
-
-
-
-
-
-
New Dependency: rubocop-rspec_rails (2.28.3) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:4/6
-
-
-
-
-
-
-
-
New Dependency: ruby-progressbar (1.13.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: tzinfo (2.0.6) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed:5/6
-
-
-
-
-
-
-
-
New Dependency: unicode-display_width (2.5.0) Location:
vendor/gems/gitlab-topology-service-client/Gemfile.lockChecks passed: 6/6
-
-
-
-
-
-
-
-
New Dependency: gitlab-topology-service-client (0.1) Location:
Gemfile.lockChecks passed:2/5
-
-
-
-
-
-
-
-
- Last reply by Ottilia Westerlund
2 Warnings This merge request is quite big (515 lines changed), please consider splitting it into multiple merge requests. b6f602bb: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please run
spec/dot_gitlab_ci/job_dependency_spec.rblocally to confirm that the configuration is valid. This test can be slow and is quarantined in CI for now.Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-fosssecuritydev- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Category Reviewer Maintainer backend @ivaneG
(UTC+1, 1 hour behind author)@radbatnag (UTC+8, 6 hours ahead of author)~"Pipeline configuration" Reviewer review is optional for ~"Pipeline configuration" @ddieulivol (UTC+2, same timezone as author)Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
Rubygems
This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by Ghost Usermentioned in issue #451052 (closed)
mentioned in issue #473198
requested review from @tkuah
- Resolved by Thong Kuah
$ diff -r vendor/gems/gitlab-topology-service-client/ ~/code/topology-service/clients/ruby/ Only in /Users/tkuah/code/topology-service/clients/ruby: .gitignore Only in vendor/gems/gitlab-topology-service-client: .gitlab-ci.yml Only in /Users/tkuah/code/topology-service/clients/ruby: .rspec Only in /Users/tkuah/code/topology-service/clients/ruby: .rspec_status Only in /Users/tkuah/code/topology-service/clients/ruby: .rubocop.yml Only in vendor/gems/gitlab-topology-service-client: CODEOWNERS Only in vendor/gems/gitlab-topology-service-client: GITLAB.md diff -r vendor/gems/gitlab-topology-service-client/gitlab-topology-service-client.gemspec /Users/tkuah/code/topology-service/clients/ruby/gitlab-topology-service-client.gemspec 16,33c16,22 < spec.files = [ < ".rspec", < ".rubocop.yml", < "Gemfile", < "Gemfile.lock", < "gitlab-topology-service-client.gemspec", < "lib/gitlab/cells/topology_service.rb", < "lib/gitlab/cells/topology_service/version.rb", < "lib/proto/cell_info_pb.rb", < "lib/proto/claim_service_pb.rb", < "lib/proto/claim_service_services_pb.rb", < "lib/proto/classify_service_pb.rb", < "lib/proto/classify_service_services_pb.rb", < "lib/proto/health_service_pb.rb", < "lib/proto/health_service_services_pb.rb", < "lib/proto/sequence_service_pb.rb", < "lib/proto/sequence_service_services_pb.rb" < ] --- > # Specify which files should be added to the gem when it is released. > # The `git ls-files -z` loads the files in the RubyGem that have been added into git. > spec.files = Dir.chdir(__dir__) do > `git ls-files -z`.split("\x0").reject do |f| > (f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|circleci)|appveyor)}) > end > end Only in /Users/tkuah/code/topology-service/clients/ruby: specLooks like there's some diffs.
Edited by Thong Kuah - Last reply by Thong Kuah
- Resolved by Thong Kuah
Thanks @OmarQunsulGitlab - Just some minor suggestions from me.
- Last reply by Omar Qunsul
removed review request for @tkuah
added 852 commits
-
d078c9d1...60542727 - 850 commits from branch
master - a5aeace1 - Integrate Topology Service Gem into GitLab
- d9f878d9 - Updating the Gem to the latest version
-
d078c9d1...60542727 - 850 commits from branch
