Pipeline dropdown: Fix spacing and border-radius
What does this MR do and why?
Pipeline dropdown: Fix spacing and border-radius
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
Pipeline dropdown (spacing/alignment of buttons) | |
![]() |
![]() |
Pipeline dropdown detail page (border-radius) | |
![]() |
![]() |
How to set up and validate locally
- Go to the pipeline overview page: http://gdk.test:3000/flightjs/Flight/-/pipelines?page=5&scope=all
- Go to a pipeline detail page, e.g.: http://gdk.test:3000/flightjs/Flight/-/pipelines/9
Related to #452231 (closed)
Merge request reports
Activity
changed milestone to %17.3
requested review from @clavimoniere
assigned to @seggenberger
added UX UX Paper Cuts bugux frontend grouppipeline execution sectiondev typebug labels
added devopsmanage label
added devopsverify label and removed devopsmanage label
added devopsmanage groupux paper cuts sectioncore platform labels and removed devopsverify grouppipeline execution sectiondev labels
added pipelinetier-1 label
FYI @afontaine @mrincon
Reviewer roulette
Category Reviewer Maintainer frontend @marina.mosti
(UTC+2, same timezone as author)
@ntepluhina
(UTC+2, same timezone as author)
UX @veethika
(UTC+0, 2 hours behind author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
Tailwind CSS
Legacy CSS utility classes
The following files contain legacy CSS utility classes:
-
app/assets/javascripts/ci/pipeline_details/graph/components/stage_column_component.vue
-
gl-text-truncate
- Tailwind CSS equivalent:gl-truncate
-
We are in the process of migrating our CSS utility classes to Tailwind CSS. The above CSS utility classes do not comply with Tailwind CSS naming conventions. Please use the Tailwind CSS equivalent if it is available. For more information see Tailwind CSS developer documentation.
If the Tailwind CSS equivalent is not available, it is okay to use the legacy CSS utility class for now. The Tailwind CSS equivalent will be made available when the corresponding migration issue in &13521 (closed) is completed.
If a legacy CSS utility class is listed above but you did not change it in this MR it is okay to leave for now. If it is a small or simple MR, feel free to leave the code better than you found it and migrate those legacy CSS utility classes to Tailwind CSS.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
added grouppipeline execution label and removed groupux paper cuts label
added 1 commit
- b19e9126 - Pipeline dropdown: Fix spacing and border-radius
- Resolved by Chad Lavimoniere
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
- Resolved by Natalia Tepluhina
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you resolve this discussion, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 486b7eb4expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 67 | 0 | 2 | 0 | 69 | ✅ | | Verify | 44 | 0 | 3 | 0 | 47 | ✅ | | Govern | 69 | 0 | 0 | 0 | 69 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 373 | 0 | 30 | 0 | 403 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 486b7eb4expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 30 | 0 | 15 | 2 | 45 | ✅ | | Create | 278 | 0 | 34 | 40 | 312 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 320 | 0 | 49 | 42 | 369 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
- Resolved by Natalia Tepluhina
Hey @marina.mosti can you do the frontend review here? TY!