Resolve "Broken master: ee/spec/services/slash_commands/global_slack_handler_spec.rb"
requested to merge 14634-broken-master-ee-spec-services-slash_commands-global_slack_handler_spec-rb into master
What does this MR do?
Fix master - Pass in a nil project to Gitlab::SlashCommands::ApplicationHelp.new
if the chatops command is help
. Modify the Gitlab::SlashCommands::Presenters::Help
message to conditionally skip printing out project information if there is no project given.
CE port: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32518
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #14634 (closed)
Edited by charlie ablett