CI/CD Settings: Migrates settings blocks to SettingsBlock
What does this MR do and why?
CI/CD Settings: Migrates settings blocks to SettingsBlock
Note: We split the efforts in two parts here as otherwise the MR would be very big. There will be a Part 2 where we migrate the rest of gl-new-cards
to use CrudComponent
. There is one migration in this MR.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
Project | |
![]() |
![]() |
Group | |
![]() |
![]() |
How to set up and validate locally
- http://gdk.test:3000/flightjs/Flight/-/settings/ci_cd
- http://gdk.test:3000/groups/flightjs/-/settings/ci_cd
Related to #452231 (comment 1880770418)
Merge request reports
Activity
changed milestone to %17.3
assigned to @seggenberger
added devopsmanage label
added sectioncore platform label and removed sectiondev label
added pipelinetier-1 label
- A deleted user
added backend label
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/views/projects/settings/ci_cd/show.html.haml
- %section.settings#autodevops-settings.no-animate{ class: ('expanded' if expanded), data: { testid: 'autodevops-settings-content' } } + testid: 'autodevops-settings-content', - %section.settings.no-animate#js-runners-settings{ class: ('expanded' if expand_runners), data: { testid: 'runners-settings-content' } } + testid: 'runners-settings-content', - %section.settings.no-animate#js-cicd-variables-settings{ class: ('expanded' if expanded), data: { testid: 'variables-settings-content' } } + testid: 'variables-settings-content',
ee/app/assets/javascripts/protected_environments/protected_environments.vue
- <span class="gl-new-card-count" data-testid="protected-environments-count"> - data-testid="new-environment-button" - data-testid="protected-environment-item-toggle" + data-testid="protected-environment-item-toggle"
ee/app/views/projects/settings/ci_cd/_pipeline_subscriptions.html.haml
-%section.settings.no-animate#pipeline-subscriptions{ class: ('expanded' if expanded), data: { testid: 'pipeline-subscriptions-setting-content' } } + testid: 'pipeline-subscriptions-setting-content',
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer backend @sam.figueroa
(UTC+0, 2 hours behind author)
@jessieay
(UTC-7, 9 hours behind author)
frontend @thutterer
(UTC+2, same timezone as author)
@psjakubowska
(UTC+2, same timezone as author)
UX @clavimoniere
(UTC-4, 6 hours behind author)
Maintainer review is optional for UX ~"Verify" Reviewer review is optional for ~"Verify" @tianwenchen
(UTC+10, 8 hours ahead of author)
~"Verify" Reviewer review is optional for ~"Verify" @lma-git
(UTC-7, 9 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 1ac9b9ec - CI/CD Settings: Migrates settings blocks to SettingsBlock
added 1 commit
- 40e49ca7 - CI/CD Settings: Migrates settings blocks to SettingsBlock
requested review from @rhardarson and @annabeldunstone
- Resolved by Jose Ivan Vargas
added 1 commit
- c189858b - CI/CD Settings: Migrates settings blocks to SettingsBlock
requested review from @jivanvl
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
- Resolved by Ragnar Hardarson
- Resolved by Jose Ivan Vargas
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you resolve this discussion, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for c189858bexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 67 | 0 | 2 | 0 | 69 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Govern | 69 | 0 | 0 | 0 | 69 | ✅ | | Verify | 44 | 0 | 3 | 0 | 47 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 373 | 0 | 30 | 0 | 403 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for c189858bexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 30 | 0 | 15 | 2 | 45 | ✅ | | Create | 274 | 0 | 34 | 40 | 308 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 310 | 0 | 49 | 42 | 359 | ✅ | +--------+--------+--------+---------+-------+-------+--------+