Skip to content

Hide pending todos authored by banned users

Ruby Nealon requested to merge rubynealon/hide-pending-todos-from-banned-users into master

What does this MR do and why?

Hide pending todos authored by banned users

Content by banned users is "hidden" from non-instance-admin users. This change brings the behavior of todos in-line with this behavior and makes sure abusive content does not remain in the todo lists of any mentioned users.

This does not apply to done items (i.e. that a user has seen) to avoid potential confusion.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create 2 users in GDK (user1 and user2)
  2. As user1, create an issue in a project that both users have visibility of and tag user2
  3. As user2 confirm the mention shows in their todo list and the count is shown as 1
  4. As root ban user1
  5. As user2 confirm the mention no longer shows in the todo list and the count is shown as 0
Edited by Ruby Nealon

Merge request reports