Skip to content

Refactor MirrorsController

Vasilii Iakliushin requested to merge 455520_move_pull_mirror_code_to_ee into master

What does this MR do and why?

Contributes to #455520

  • Move deprecated_pull_mirror_procedure to EE scope (Pull mirrors are Premium+ feature)
  • Use Gitlab::Utils.to_boolean to handle boolean-like (1, '1', true) values from frontend
  • Return an error when request is incorrect

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Create a new push mirror
  2. Create a new pull mirror
  3. Delete push and pull mirror
  4. Everything should work without any problems
Edited by Vasilii Iakliushin

Merge request reports