Skip to content

Remove `gl-line-height-14` CSS util

Paul Gascou-Vaillancourt requested to merge remove-line-height-14 into master

What does this MR do and why?

The gl-line-height-14 CSS util conflicts with the design system and has been removed along with its associated SCSS variable. Existing usages have been migrated to compliant equivalents.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Incidents > Timeline events form

  1. Create an incident in any project.
  2. In the incident's page, click on Add new timeline event.
  3. Observe the character counter in the bottom-right corner of the textarea.
Before After
Screenshot_2024-07-10_at_4.31.35_PM Screenshot_2024-07-10_at_1.42.43_PM

External issues

  1. This requires setting up Jira issues integration: https://docs.gitlab.com/ee/integration/jira/configure.html
  2. Create an issue in your Jira project. Do not assign it to any user.
  3. Back in the Gitlab project's Jira issue tracker, navigate to the Jira issue.
  4. Observe the Assignees widget in the sidebar.
Before After
Screenshot_2024-07-10_at_4.32.02_PM Screenshot_2024-07-10_at_2.27.27_PM

Escalation policy

  1. In an Ultimate group's project, create an incident.
  2. Navigate to the incident's page.
  3. Observe the Escalation policy widget in the sidebar.
Before After
Screenshot_2024-07-10_at_4.32.14_PM Screenshot_2024-07-10_at_2.44.37_PM

Subscriptions

N/A

Environments

N/A

Edited by Paul Gascou-Vaillancourt

Merge request reports