Change the unit primitive for troubleshoot job
What does this MR do and why?
This adds the unit primitive for the /troubleshoot_job
slash command tool.
Similar too: !157606 (merged)
Part of making this available to Enterprise Duo customers only. Issue: #457573 (closed)
Merge request reports
Activity
assigned to @allison.browne
added pipelinetier-1 label
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@allison.browne
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
changed milestone to %17.2
- A deleted user
added backend label
5 Warnings f27fc747: The commit subject must not end with a period. For more information, take a look at our Commit message guidelines. d096ce96: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. dc2c9f7f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.2 Messages This merge request includes changes to Vue files that have both CE and EE versions. CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Vue
<template>
in CE and EESome Vue files in CE have a counterpart in EE. (For example,
path/to/file.vue
andee/path/to/file.vue
.)When run in the context of CE, the
<template>
of the CE Vue file is used. When run in the context of EE, the<template>
of the EE Vue file is used.It's easy to accidentally make a change to a CE
<template>
that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:
ee/app/assets/javascripts/ci/job_details/components/job_log_top_bar.vue
If you made a change to the
<template>
of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.A better alternative
An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag
Reviewer roulette
Category Reviewer Maintainer backend @jmontal
(UTC-6, 2 hours behind author)
@rutgerwessels
(UTC+2, 6 hours ahead of author)
frontend @dzubova
(UTC+2, 6 hours ahead of author)
@anna_vovchenko
(UTC+3, 7 hours ahead of author)
test for spec/features/*
@jmontal
(UTC-6, 2 hours behind author)
Maintainer review is optional for test for spec/features/*
groupauthorization Reviewer review is optional for groupauthorization @hmehra
(UTC+10, 14 hours ahead of author)
~"Verify" Reviewer review is optional for ~"Verify" @avielle
(UTC+2, 6 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Gosia Ksionek
@missy-gitlab, could you review this MR?
requested review from @missy-gitlab
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
- Resolved by Gosia Ksionek
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you resolve this discussion, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
requested review from @mksionek and removed review request for @missy-gitlab
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 5f1fdbe7expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 69 | 0 | 0 | 0 | 69 | ✅ | | Plan | 67 | 0 | 2 | 0 | 69 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Verify | 44 | 0 | 3 | 0 | 47 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 373 | 0 | 30 | 0 | 403 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 5f1fdbe7expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Verify | 52 | 0 | 14 | 1 | 66 | ✅ | | Create | 278 | 0 | 34 | 40 | 312 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 342 | 0 | 48 | 41 | 390 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
mentioned in incident gitlab-org/quality/engineering-productivity/approved-mr-pipeline-incidents#755 (closed)
added grouppipeline execution label
- Resolved by Gosia Ksionek
Hi @allison.browne! There are more changes needed to make it work
Please see this checklist: https://gitlab.com/gitlab-org/gitlab/-/issues/444274#note_1972656569
- do we have an entry in https://gitlab.com/gitlab-org/gitlab/-/blob/b72dba0ced896de7ad96cfa76ac8b8eeeb582ede/ee/config/cloud_connector/access_data.yml
- do we have an MR in customer dot repo?
- we also need an MR in AI Gateway (like this: !156650 (merged))
Please see !156650 (merged) for reference.
added devopsverify sectionci labels
mentioned in issue #466260 (closed)
added 923 commits
-
f580ce59...3c201dd9 - 920 commits from branch
master
- bb7eb487 - Change the unit primitive for troubleshoot job
- f2f8020d - Add troubleshoot_job to access_data.yml
- cdea109f - Add more unit primitive boilerplate
Toggle commit list-
f580ce59...3c201dd9 - 920 commits from branch
- Resolved by Gosia Ksionek
changed milestone to %17.3
added missed:17.2 label
added 699 commits
-
d7ace1d1...275b9b89 - 695 commits from branch
master
- 21dece0e - Change the unit primitive for troubleshoot job
- d5e2e449 - Add troubleshoot_job to access_data.yml
- dc2c9f7f - Add more unit primitive boilerplate
- d096ce96 - Add build policy specs
Toggle commit list-
d7ace1d1...275b9b89 - 695 commits from branch
- Resolved by Gosia Ksionek
Thanks @mksionek, sending this back over to you.
- Resolved by Gosia Ksionek
@jivanvl, I've added some additional gating of the feature on the backend based on the duo enterprise license. I've pushed the ability to the front end, like so:
push_frontend_ability(ability: :troubleshoot_job_with_ai, resource: @build, user: @current_user)
Can we gate the feature on the front end side using this check in
rootCauseAnalysisDuoIsAvailable
andaiRootCauseAnalysisAvailable
?We only want to show
rootCauseAnalysisDuoIsAvailable
iftroubleshoot_job_with_ai
is true.Do you want to commit directly to this branch? otherwise we could do it in 3 MRs:
- introduce backend ability and
push_frontend_ability
- Use that on the frontend
- Use that on the backend
To avoid ending up in a state where the frontend has access but the backend does not.
Edited by Allison Browne - introduce backend ability and
added 1 commit
- f27fc747 - Push the new troubleshoot_job_with_ai ability.
added 1 commit
- 6c27594d - Add ability check to the Frontend for job logs
- A deleted user
added frontend label
mentioned in issue jivanvl/manager-of-one#16 (closed)
added pipelinetier-3 label and removed pipelinetier-2 label
- Resolved by Gosia Ksionek
- Resolved by Gosia Ksionek
I left one small comment.
Also: pipeline failures are legit, please take a look.
I have a question: are AI gateway updated for this unit primitive?
added typefeature label
mentioned in issue #466262 (closed)
- Resolved by Gosia Ksionek
@allison.browne can you please fix pipeline so I can merge?
added pipeline:skip-undercoverage label
@mfanGitLab, this one needs verify approval too. Can you take a look?
requested review from @mfanGitLab
Hey @mokhax !
Are you able to help review this MR from anauthorization
point of view? Would be great if we could get this in sooner rather than laterrequested review from @mokhax
removed this merge request from the merge train because pipeline did not succeed. Learn more.
added workflowstaging-canary label
mentioned in issue #473802 (closed)
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #473481 (closed)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request !160438 (merged)
mentioned in merge request !161878 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label