Skip to content

Handle all types of SemverDialect errors

Shao Ming Tan requested to merge smtan/rescue-all-semver-dialects-error-types into master

What does this MR do and why?

Previously, we were only rescuing SemverDialects::InvalidVersionError. This could cause an unhandled exception if SemverDialects throws other errors such as InvalidConstraintError or IncompleteScanError.

This MR rescues the general SemverDialects::Error, ensuring that all errors are handled gracefully.

Note that tests for InvalidConstraintError would be added in Draft: Update semver-dialects gem to 3.3.0 to a... (!158867) once semver-dialects 3.30 has been released.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Shao Ming Tan

Merge request reports