Skip to content

Allow authors of personal snippets and instance admins to administer notes/comments by other users in line with behavior of other Noteable

Ruby Nealon requested to merge rubynealon/delete-comments-on-own-personal-snippets into master

What does this MR do and why?

Currently, authors of personal snippets and GitLab instance admins cannot edit or delete any notes/comments left on them by other users. This MR allows them to, which brings the behavior in line with how notes/comments work on project snippet notes/comments.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Before After

How to set up and validate locally

  1. Load GDK and create 2 users (user_a and user_b)
  2. As user_a, create a personal snippet with public permissions
  3. As user_b, create a comment/note on user_a's personal snippet created in the previous step
  4. As user_a, confirm you can edit/delete user_b's comment/note
  5. As root or your admin user, confirm you can edit/delete user_b's comment/note
Edited by Ruby Nealon

Merge request reports