Skip to content

Update static_holmes to v0.7.11

Stan Hu requested to merge sh-bump-charlock-holmes into master

What does this MR do and why?

This fixes build errors with ICU 75.1, which now requires C++17 to work. ArchLinux ships with ICU 75.1 now, and Homebrew will shortly (https://github.com/Homebrew/homebrew-core/pull/169239).

Diff: https://my.diffend.io/gems/static_holmes/0.7.7/0.7.11

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Run bundle install in this branch.
  2. Run bundle exec irb and run a test:
require 'charlock_holmes'
CharlockHolmes::Converter.convert("test-me", "UTF-8", "UTF-16")
=> "\xFF\xFE\x74\x00\x65\x00\x73\x00\x74\x00\x2D\x00\x6D\x00\x65\x00"

Also see the tests in https://gitlab.com/gitlab-org/ruby/gems/charlock_holmes/-/blob/master/.gitlab-ci.yml?ref_type=heads.

Edited by Stan Hu

Merge request reports