Skip to content

Skip quarantined specs in scripts/rspec_check_order_dependence

Peter Leitzen requested to merge pl-rspec-check-order-quarantine into master

What does this MR do and why?

By default, quarantined specs are run locally so we should skip them in scripts/rspec_check_order_dependence as these specs will most-likely fail.

Refs !157845 (comment 1987565502)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. scripts/rspec_check_order_dependence spec/views/
scripts/rspec_check_order_dependence spec/views/
+ export RSPEC_WARN_MISSING_FEATURE_CATEGORY=0
+ RSPEC_WARN_MISSING_FEATURE_CATEGORY=0
+ echo 'Running in defined order:'
Running in defined order:
+ bin/rspec --order defined --format progress --tag '~quarantine' spec/views/
Running via Spring preloader in process 529838
warning: parser/current is loading parser/ruby32, which recognizes 3.2.4-compliant syntax, but you are running 3.2.3.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
Run options:
  include {:focus=>true}
  exclude {:quarantine=>true}

All examples were filtered out; ignoring {:focus=>true}

Test environment set up in 1.26254522 seconds
...................................................................................................................................................................................................................DEPRECATION WARNING: The asset "highlight/themes/solarised-light.css" is not present in the asset pipeline.
Falling back to an asset that may be in the public folder.
This behavior is deprecated and will be removed.
To bypass the asset pipeline and preserve this behavior,
use the `skip_pipeline: true` option.
 (called from universal_stylesheet_link_tag at /home/peter/devel/gitlab/gdk/gitlab/app/helpers/vite_helper.rb:33)
DEPRECATION WARNING: The asset "highlight/themes/solarised-light.css" is not present in the asset pipeline.
Falling back to an asset that may be in the public folder.
This behavior is deprecated and will be removed.
To bypass the asset pipeline and preserve this behavior,
use the `skip_pipeline: true` option.
 (called from universal_path_to_stylesheet at /home/peter/devel/gitlab/gdk/gitlab/app/helpers/vite_helper.rb:39)
..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 6 minutes 24 seconds (files took 4.77 seconds to load)
765 examples, 0 failures

Randomized with seed 9833
  1. The first run no longer fails compare to master. See !157845 (comment 1987565502)
Edited by Peter Leitzen

Merge request reports