Skip to content

Public MR-level approval state API endpoint

Patrick Bajao requested to merge 13712-public-mr-approval-state-api into master

What does this MR do?

This endpoint behaves the same way as the existing private /approval_settings API endpoint.

The difference is that this endpoint responds with eligible_approvers instead of approvers.

The private endpoint should be removed in https://gitlab.com/gitlab-org/gitlab-ee/issues/13574 together with the private project-level endpoints.

docs MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32445

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

#13712 (closed)

Edited by Patrick Bajao

Merge request reports