Skip to content

Improve Remote Dev integration spec to cover static vars

Chad Woolley requested to merge caw-rd-improve-integration-spec into master

What does this MR do and why?

Improves Remote Dev integration spec. Add coverage for static variables, which was missing.

Since ee/spec/lib/remote_development/workspaces/create/main_integration_spec.rb mocks out the Settings passed in the context into the ROP chain, this meant there was a coverage hole if we broke something in the API between the settings module and the ROP chain.

This could cause bugs if there was some error in the Settings module, API, or service layer where we didn't correctly pass down an expected setting which was used to generate a static variable.

And it did happen, the work in Move extensions marketplace settings to webide ... (!157999 - merged) initially broke this contract and introduced a bug where one of the variables was not correctly passed, but no tests failed.

With this MR, that coverage hole is plugged, and any incorrect static variables will cause

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports