Remove pages from navigation when disabled in settings

Niklas van Schrickrequested to merge
gitlab-community/gitlab-org/gitlab:471067-menu-out-of-standard into master
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

Remove pages from navigation when disabled in settings

Currently the pages menu entry stays in the navigation, even if the feature is disabled in the settings and renders a page telling you that the feature is disabled. It doesn't allow you to turn the feature on, so it can probably just be removed.

This also allows to remove navigation items from a project that don't make sense in the context of that project.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Pages enabled Pages disabled
image image

How to set up and validate locally

  • Enable access_control for pages in config/gitlab.yml
  • Open a project and check that Deploy > Pages is present
  • Go to the settings and disable Pages
  • Check that Deploy > Pages is not present

Related to #471067 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports