Skip to content

Prevent modal close on comment submission

Dheeraj Joshi requested to merge djadmin-fix-comment-handle-save into master

What does this MR do and why?

This fixes a bug with submitting comments on an issue page. We show the user a warning modal when the comment has a secret in it, and this MR destroys the event, preventing the page from reloading while submitting the comment.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Presently, when the warning modal appears, the page gets reloaded.

Before After
2024-07-05_23.25.46 2024-07-05_23.24.53

How to set up and validate locally

  1. Open any issue on gdk instance
  2. Enter glrt-2CR8_eVxiioB1QmzPZwa to trigger warning modal.
  3. The page should not reload when the modal appears.
Edited by Dheeraj Joshi

Merge request reports