Skip to content

Remove migration-related columns on ContainerRepository

What does this MR do and why?

Issue link: #409873 (closed)

In this MR, we are removing the ignored columns that are related to the container registry migration.

  • migration_plan
  • migration_aborted_at
  • migration_skipped_at
  • migration_import_done_at
  • migration_import_started_at
  • migration_pre_import_done_at
  • migration_pre_import_started_at

The columns were ignored during last milestone, %17.1, in !153518 (merged)

This is step 2 of 3 when removing columns as per the guidelines.

Results of the migration (up)

main: == [advisory_lock_connection] object_id: 128500, pg_backend_pid: 31406
main: == 20240705191615 RemoveMigrationDateFieldsFromContainerRepository: migrating =
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- remove_column(:container_repositories, :migration_plan)
main:    -> 0.0008s
main: -- remove_column(:container_repositories, :migration_aborted_at)
main:    -> 0.0004s
main: -- remove_column(:container_repositories, :migration_skipped_at)
main:    -> 0.0004s
main: -- remove_column(:container_repositories, :migration_import_done_at)
main:    -> 0.0002s
main: -- remove_column(:container_repositories, :migration_import_started_at)
main:    -> 0.0002s
main: -- remove_column(:container_repositories, :migration_pre_import_done_at)
main:    -> 0.0002s
main: -- remove_column(:container_repositories, :migration_pre_import_started_at)
main:    -> 0.0002s
main: == 20240705191615 RemoveMigrationDateFieldsFromContainerRepository: migrated (0.0165s)

Results of the migration (down)

main: == [advisory_lock_connection] object_id: 128040, pg_backend_pid: 32040
main: == 20240705191615 RemoveMigrationDateFieldsFromContainerRepository: reverting =
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- add_column(:container_repositories, :migration_plan, :text, {:if_not_exists=>true})
main:    -> 0.0191s
main: -- add_column(:container_repositories, :migration_aborted_at, :datetime_with_timezone, {:if_not_exists=>true})
main:    -> 0.0028s
main: -- add_column(:container_repositories, :migration_skipped_at, :datetime_with_timezone, {:if_not_exists=>true})
main:    -> 0.0019s
main: -- add_column(:container_repositories, :migration_import_done_at, :datetime_with_timezone, {:if_not_exists=>true})
main:    -> 0.0018s
main: -- add_column(:container_repositories, :migration_import_started_at, :datetime_with_timezone, {:if_not_exists=>true})
main:    -> 0.0017s
main: -- add_column(:container_repositories, :migration_pre_import_done_at, :datetime_with_timezone, {:if_not_exists=>true})
main:    -> 0.0017s
main: -- add_column(:container_repositories, :migration_pre_import_started_at, :datetime_with_timezone, {:if_not_exists=>true})
main:    -> 0.0019s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE container_repositories\nADD CONSTRAINT check_05e9012f36\nCHECK ( char_length(migration_plan) <= 255 )\nNOT VALID;\n")
main:    -> 0.0008s
main: -- execute("SET statement_timeout TO 0")
main:    -> 0.0002s
main: -- execute("ALTER TABLE container_repositories VALIDATE CONSTRAINT check_05e9012f36;")
main:    -> 0.0004s
main: -- execute("RESET statement_timeout")
main:    -> 0.0002s
main: == 20240705191615 RemoveMigrationDateFieldsFromContainerRepository: reverted (0.0704s)

main: == [advisory_lock_connection] object_id: 128040, pg_backend_pid: 32040

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #409873 (closed)

Edited by Adie (she/her)

Merge request reports