Remove Vue set for vue 3 migration
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR partially resolves #452467 (closed)
What was cleaned up from epic:
- Remove
Vue.set
Vue set is no longer supported in VUE 3
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
NO VISUAL CHANGES
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Checkout branch
- Run test locally
- Or just check in pipeline
- Run it also with
VUE_VERSION=3 yarn jest --watch
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %17.2
assigned to @arfedoro
added pipelinetier-1 label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @viktomas
(UTC+2, same timezone as author)
@psimyn
(UTC+10, 8 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 93d4670d and 26328b16
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.3 MB 4.3 MB - 0.0 % mainChunk 3.25 MB 3.25 MB - 0.0 %
Note: We do not have exact data for 93d4670d. So we have used data from: 5f84a178.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Artur Fedorov
@dzubova could you please review this?
requested review from @dzubova
added 248 commits
-
c1221e19...4e7a0a67 - 247 commits from branch
master
- 26328b16 - Remove Vue set for vue 3 migration
-
c1221e19...4e7a0a67 - 247 commits from branch
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
- Resolved by Simon Knox
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you resolve this discussion, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 26328b16expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 43 | 0 | 3 | 0 | 46 | ✅ | | Create | 126 | 0 | 12 | 0 | 138 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 60 | 0 | 2 | 0 | 62 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 65 | 0 | 0 | 0 | 65 | ✅ | | Data Stores | 27 | 0 | 4 | 0 | 31 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 356 | 0 | 34 | 0 | 390 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 26328b16expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 30 | 0 | 13 | 0 | 43 | ✅ | | Secure | 3 | 0 | 2 | 0 | 5 | ✅ | | Create | 138 | 0 | 16 | 0 | 154 | ✅ | | Verify | 52 | 0 | 14 | 0 | 66 | ✅ | | Govern | 78 | 1 | 9 | 0 | 88 | ❌ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 24 | 0 | 26 | ✅ | | Plan | 83 | 0 | 11 | 0 | 94 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Package | 23 | 0 | 15 | 0 | 38 | ✅ | | Manage | 2 | 0 | 8 | 0 | 10 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 426 | 1 | 132 | 0 | 559 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
added pipelinetier-3 label and removed pipelinetier-2 label
removed this merge request from the merge train because pipeline did not succeed. Learn more.
enabled automatic add to merge train when the pipeline for 9c2ce2c6 succeeds
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label