Skip to content

ActionCable: Allow request origins from GitLab URL in dev/test

Peter Leitzen requested to merge pl-action-cable-allowed-request-origins into master

What does this MR do and why?

Prior this commit the URL was hardcoded and prevented GDK users with non-standard configuration to test action cable after the introduction of GitLab HTTP router.

Fixes gitlab-development-kit#2135 (closed).

Follow-up of !143227 (merged).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Setup local network (non-127.0.0.1 or non-gdk.test) in GDK (https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/local_network.md)
  2. gdk restart
  3. Open Issue page and verify that JavaScript no longer fails
Edited by Peter Leitzen

Merge request reports