Skip to content

Draft: Synchronize read/writes of deduplicate flag for Sidekiq jobs

Stan Hu requested to merge sh-sync-deduplicate-flag-redis into master

What does this MR do and why?

Previously if setting the deduplicate flag were too slow a job might not attempt to reschedule a job. We synchrnoize access via a separate key.

TODO:

  • See if we can reproduce the problem
  • Guard with feature flag
  • Add tests

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Stan Hu

Merge request reports