Disallow *_description properties in event definitions
requested to merge 434563-update-additional-properties-handling-in-event-definition-schema into master
What does this MR do and why?
label_description
, property_description
and value_description
was migrated to the new format:
additional_properties:
label:
description: ...
property:
description: ...
value:
description: ...
That means we can now remove label_description
, property_description
and value_description
as valid properties in event definitions.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
- Add
label_description: never never gonna give you up
toee/config/events/20210915205139_packages_cancel_delete_package.yml
- Run
rspec ./spec/lib/gitlab/tracking/event_definition_validate_all_spec.rb
and see the spec fail.
Related to #434563 (closed)
Edited by Jonas Larsen