Skip to content

Enable submit button for policy editor

Artur Fedorov requested to merge 469200-policies-disabled-submit-button into master

What does this MR do and why?

According to pajamas guidelines, submit button on forms should always be enabled

This MR enables submit button for:

  1. Pipeline execution policy
  2. Scan execution policy
  3. Approval policy

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Description UI
Pipeline execution pipeline execution.png
Scan execution scan execution.png
Approval policy scan result.png

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Enable feature flag

Feature.enable(:pipeline_execution_policy_type)
  1. Go to group/project
  2. Secure -> Policies -> New policy
  3. Try every policy type, make sure submit button is enabled by default and stay enabled on any action
  4. When trying to submit empty form ,you see the validation
  5. You can also try with existing policies

    1. enabled

    2. enabled

Related to #469200 (closed)

Merge request reports