Skip to content

Avoid fixture context leak breaking specs

Sam Figueroa requested to merge sf/fixes/flaky-spec-for-protected-branches-470326 into master

What does this MR do and why?

Avoid fixture context leak breaking specs. The shared project & group being present at different states of the feature flag seems to give this spec a tendency to be flaky. (Locally it actually failed every time for me). Previous version ran fine in isolation consistently.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  • run rspec ./ee/spec/models/approval_project_rule_spec.rb
Edited by Sam Figueroa

Merge request reports