Default cube analytics queries to the last 7 days
What does this MR do and why?
Default cube analytics queries to the last 7 days to resolve [Product analytics] Default to a 7 day date ran... (#469488 - closed). The only impact of this change is on the visualization designer which now limits the preview to the last 7 days instead of querying events over all time which would result in slow performance, unreadable charts or even crashing the UI.
I've also added a temporary help icon with tooltip to explain this on the UI. This will be superseded by a full date range filter we'll be adding to the visualization designer in Allow filtering product analytics visualization... (#462618).
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Designer
Before | After |
---|---|
![]() |
![]() |
Dashboards
No visual change.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #469488 (closed)
Merge request reports
Activity
changed milestone to %17.2
assigned to @jiaan
added typefeature label and removed typebug label
removed bugfunctional label
removed featureenhancement label
added pipelinetier-1 label
- Resolved by Olena Horal-Koretska
1 Warning This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/analytics/analytics_dashboards/components/visualization_designer/analytics_visualization_preview.vue
- :data-testid="`select-${buttonDisplayType.type}-button`" + :data-testid="`select-${buttonDisplayType.type}-button`"
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @a_akgun
(UTC+3, 1 hour ahead of author)
@ohoral
(UTC+0, 2 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
Tailwind CSS
Legacy CSS utility classes
The following files contain legacy CSS utility classes:
-
ee/app/assets/javascripts/analytics/analytics_dashboards/components/visualization_designer/analytics_visualization_preview.vue
-
gl-display-flex
- Tailwind CSS equivalent:gl-flex
-
gl-align-self-end
- Tailwind CSS equivalent:gl-self-end
-
We are in the process of migrating our CSS utility classes to Tailwind CSS. The above CSS utility classes do not comply with Tailwind CSS naming conventions. Please use the Tailwind CSS equivalent if it is available. For more information see Tailwind CSS developer documentation.
If the Tailwind CSS equivalent is not available, it is okay to use the legacy CSS utility class for now. The Tailwind CSS equivalent will be made available when the corresponding migration issue in &13521 (closed) is completed.
If a legacy CSS utility class is listed above but you did not change it in this MR it is okay to leave for now. If it is a small or simple MR, feel free to leave the code better than you found it and migrate those legacy CSS utility classes to Tailwind CSS.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User-
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 2529c664 and ff012ea2
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.29 MB 4.29 MB - 0.0 % mainChunk 3.25 MB 3.25 MB - 0.0 %
Note: We do not have exact data for 2529c664. So we have used data from: 26a74d4e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost User Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7254344245 ee/spec/features/projects/analytics/dashboards_spec.rb#L94
Analytics Dashboard - Value Streams Dashboard with a valid user with combined_project_analytics_dashboards and project_level_analytics_dashboard license for Value streams dashboard does not render dora performers score panel 54.55 s < 50.13 s #7265144217 ee/spec/features/projects/analytics/dashboards_spec.rb#L94
Analytics Dashboard - Value Streams Dashboard with a valid user with combined_project_analytics_dashboards and project_level_analytics_dashboard license for Value streams dashboard does not render dora performers score panel 50.6 s < 50.13 s Edited by Ghost User- A deleted user
added rspec:slow test detected label
- Resolved by Lorena Ciutacu
added Technical Writing label
requested review from @lciutacu
removed review request for @lciutacu