Skip to content

Remove unnecessary stubs from organization_helper_spec.rb

What does this MR do and why?

Related to #469135 (closed)

Follow-up from !157087 (comment 1967070969). There were a number of unnecessary stubs in organization_helper_spec.rb that we can remove to improve test coverage. This MR removes those stubs. A few of the stubs were needed for the illustration paths but we can actually directly import these illustrations on the frontend and avoid having to pass them from Rails. This simplifies everything and allows us to remove the stubs from the specs.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No visual changes, showing that nothing has changed after switching to directly importing illustrations on the frontend

Your work -> Organizations

Before After
Screenshot_2024-07-02_at_3.06.48_PM Screenshot_2024-07-02_at_3.01.36_PM

Admin area -> Organizations

Before After
Screenshot_2024-07-02_at_3.06.39_PM Screenshot_2024-07-02_at_3.00.38_PM

Organization -> Groups

Before After
Screenshot_2024-07-02_at_3.07.02_PM Screenshot_2024-07-02_at_3.02.38_PM

Organization -> Projects

Before After
Screenshot_2024-07-02_at_3.07.16_PM Screenshot_2024-07-02_at_3.03.34_PM

How to set up and validate locally

Run bin/rspec spec/helpers/organizations/organization_helper_spec.rb

Edited by Peter Hegman

Merge request reports