Follow-up from "Hide `New subgroup` button if visibility is restricted"

• Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

Extract the logic for the allowed levels from the group policy to the visibility level. This brings more simplicity to the group policy.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

This change should be purely refactoring, but you can check if the button to create a subgroup is behaving as usual.

Related to #455557 (closed)

added devopsdata stores grouptenant scale sectioncore platform typemaintenance labels

added pipelinetier-1 label

Thanks for your contribution to GitLab @MAlvarez32!

• If you need help, comment @gitlab-bot help or come say hi on Discord.
• When you're ready for a review, comment on this merge request with @gitlab-bot ready.
• We welcome AI-generated contributions! Read more/check the box at the top of the merge request description.
• To add labels to your merge request, comment @gitlab-bot label ~"label1" ~"label2".

This message was generated automatically. You're welcome to improve it.

added Community contribution workflowin dev labels

assigned to @MAlvarez32

changed the description

added linked-issue label

	1 Warning
	Labels missing: please ask a reviewer or maintainer to add backend to this merge request.

	1 Message
	CHANGELOG missing: If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@thutterer (UTC+2)	@rzwambag (UTC+2)
groupauthorization	Reviewer review is optional for groupauthorization	@mokhax (UTC-6)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

• 37abde06 - Return the allowed levels as the name of the method suggests

Compare with previous version

added 1 commit

• 0fac40a6 - Add spec for allowed_levels_for_user

Compare with previous version

changed the description

@gitlab-bot ready

added workflowready for review label and removed workflowin dev label

Hi Coach @jrushford, this Community contribution is ready for review or needs your coaching.

• Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
• If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.

This message was generated automatically. You're welcome to improve it.

requested review from @jrushford

Hi @alexbuijs could you please do the intial review on this one please?

requested review from @alexbuijs and removed review request for @jrushford

approved this merge request

requested review from @brytannia and removed review request for @alexbuijs

added pipeline:mr-approved label

added pipelinetier-2 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.

Before you resolve this discussion, please check the following:

• You are the last maintainer of this merge request
• The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
• This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

Thanks @MAlvarez32 I left a few comments for your concideration

changed milestone to %17.2

added workflowin dev label and removed workflowready for review label

added 1 commit

• 63c178e5 - Apply review comments to improve specs

Compare with previous version

@brytannia Sorry for the delay. Thank you for your feedback, I applied your suggestions ^^

changed milestone to %17.3

added 1 commit

• b6e3f658 - Adapt specs to four-phase test paradigm

Compare with previous version

added 1 commit

• 86f89dfd - Stub settings to return different visibility levels

Compare with previous version

resolved all threads

approved this merge request

added pipelinetier-3 label and removed pipelinetier-2 label

enabled automatic add to merge train when checks pass

added backend label

	1 Message
	CHANGELOG missing: If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@bauerdominic (UTC+2)	@rzwambag (UTC+2)
groupauthorization	Reviewer review is optional for groupauthorization	@alexbuijs (UTC+2)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 86f89dfd

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 127    | 0      | 12      | 0     | 139   | ✅     |
| Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
| Plan        | 66     | 0      | 3       | 0     | 69    | ✅     |
| Data Stores | 30     | 0      | 1       | 0     | 31    | ✅     |
| Package     | 19     | 0      | 12      | 0     | 31    | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Govern      | 69     | 0      | 0       | 0     | 69    | ✅     |
| Secure      | 1      | 0      | 0       | 0     | 1     | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 371    | 0      | 31      | 0     | 402   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 86f89dfd

expand test summary

+---------------------------------------------------------------------+
|                           suites summary                            |
+----------------+--------+--------+---------+-------+-------+--------+
|                | passed | failed | skipped | flaky | total | result |
+----------------+--------+--------+---------+-------+-------+--------+
| Govern         | 105    | 0      | 8       | 2     | 113   | ✅     |
| Manage         | 29     | 1      | 15      | 2     | 45    | ❌     |
| Package        | 31     | 0      | 14      | 7     | 45    | ✅     |
| Systems        | 7      | 0      | 0       | 0     | 7     | ✅     |
| Verify         | 50     | 1      | 15      | 2     | 66    | ❌     |
| Plan           | 79     | 0      | 12      | 0     | 91    | ✅     |
| Create         | 417    | 0      | 51      | 9     | 468   | ✅     |
| Monitor        | 12     | 0      | 13      | 0     | 25    | ✅     |
| Fulfillment    | 4      | 0      | 7       | 0     | 11    | ✅     |
| Data Stores    | 46     | 0      | 11      | 0     | 57    | ✅     |
| GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
| Analytics      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Configure      | 1      | 0      | 3       | 0     | 4     | ✅     |
| Ai-powered     | 1      | 0      | 2       | 0     | 3     | ✅     |
| Release        | 5      | 0      | 1       | 0     | 6     | ✅     |
| Secure         | 4      | 0      | 2       | 0     | 6     | ✅     |
| Growth         | 0      | 0      | 2       | 0     | 2     | ➖     |
| ModelOps       | 0      | 0      | 1       | 0     | 1     | ➖     |
+----------------+--------+--------+---------+-------+-------+--------+
| Total          | 796    | 2      | 158     | 22    | 956   | ❌     |
+----------------+--------+--------+---------+-------+-------+--------+

mentioned in incident gitlab-org/quality/engineering-productivity/approved-mr-pipeline-incidents#870 (closed)

started a merge train

merged

@MAlvarez32, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

1. React with a or a on this comment to describe your experience.
2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

Thanks for your help!

This message was generated automatically. You're welcome to improve it.

mentioned in commit 54b6d582

added workflowstaging-canary label and removed workflowin dev label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-production label and removed workflowproduction label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

mentioned in issue #455557 (closed)