Skip to content

Rename bot? and vpn? to is_bot and is_vpn

Eugie Limpin requested to merge el-rename-methods into master

What does this MR do and why?

Implements #469104 (closed)

The new names match the Arkose response field. The previous names were also misleading since they can return nil.

Note: These methods intentionally do not default to false since we want to know if these values are nil (Arkose likely returned an unexpected response).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports