Skip to content

Removes the custom zoom icon for insights chart

Ezekiel Kigbo requested to merge ek-remove-get-svg-icon-path-content-from-insights into master

What does this MR do and why?

Removes the custom zoom icon for insights chart, the default zoom svg is set in gitlab-ui instead so this is no longer needed

This MR:

  • Updates the storybook stories
  • Removes the getSvgIconPathContent prop that is no longer used

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
inisghts-svg-before inisghts-svg-after

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Open gitlab storybook from gdk directory, run $ yarn storybook:start
  2. Select the insights chart, move the zoom slider below the top line chart
  3. Run your local GDK
  4. Navigate to the insights page for any project Analyze > Insights
  5. Interact with the zoom slider on the page

Related to #469190 (closed)

Edited by Ezekiel Kigbo

Merge request reports