Skip to content
Snippets Groups Projects

Add filters to import source users Graphql resolver

Merged Add filters to import source users Graphql resolver
rodrigo/add-filters-to-import-user-source-graphql into master
All threads resolved!
Merged Rodrigo Tomonari requested to merge rodrigo/add-filters-to-import-user-source-graphql into master
All threads resolved!

What does this MR do and why?

Update the resolver to filter and sort results.

Related to: #455902 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. Create sample Import::SourceUser records using Rails console
10000.times do 
  status = Import::SourceUser.state_machines[:status].states.map(&:value).sample

  reassign_to_user = [1, 2, 3, 4, 5].include?(status) ? User.where(user_type: 0).order("RANDOM()").limit(1).first : nil
  reassigned_by_user = [1, 2, 3, 4, 5, 6].include?(status) ? User.first : nil

  FactoryBot.create(
    :import_source_user, 
    reassign_to_user: reassign_to_user, 
    reassigned_by_user: reassigned_by_user, 
    namespace: Group.where(parent: nil).order("RANDOM()").limit(1).first, 
    source_name: FFaker::Name.unique.name, 
    source_username: FFaker::Internet.unique.user_name,
    status: status
  )
end
  1. Enable feature flag bulk_import_user_mapping using Rails console
  2. Use http://gdk.test:3000/-/graphql-explorer to test the API
{
  group(fullPath: "toolbox") {
    importSourceUsers(statuses: [AWAITING_APPROVAL, REJECTED], sort: STATUS_ASC, search: "Adr") {
     	nodes {
        id
        status
        sourceName
        sourceUsername
        placeholderUser {
          id
          name
        }
        reassignedByUser {
          id
          name
        }
        reassignToUser {
          id
          name
        }
      } 
    }
  }
}

SQL queries

SQL 1

Raw SQL 
SELECT
    "import_source_users".*
FROM
    "import_source_users"
WHERE
    "import_source_users"."namespace_id" = 22
ORDER BY
    "import_source_users"."source_name" ASC,
    "import_source_users"."id" DESC
LIMIT 101

Query plan: https://explain.depesz.com/s/igtk

SQL 2

Raw SQL 
SELECT
    "import_source_users".*
FROM
    "import_source_users"
WHERE
    "import_source_users"."namespace_id" = 22
    AND "import_source_users"."status" IN (1, 3)
ORDER BY
    "import_source_users"."source_name" ASC,
    "import_source_users"."id" DESC
LIMIT 101

Query plan: https://explain.depesz.com/s/KYqW

SQL 3

Raw SQL 
SELECT
    "import_source_users".*
FROM
    "import_source_users"
WHERE
    "import_source_users"."namespace_id" = 22
    AND "import_source_users"."status" IN (1, 3)
    AND ("import_source_users"."source_name" ILIKE '%Adr%'
        OR "import_source_users"."source_username" ILIKE '%Adr%')
ORDER BY
    "import_source_users"."source_name" ASC,
    "import_source_users"."id" DESC
LIMIT 101

Query plan: https://explain.depesz.com/s/6wDX

SQL 4

Raw SQL 
SELECT
    "import_source_users".*
FROM
    "import_source_users"
WHERE
    "import_source_users"."namespace_id" = 22
    AND "import_source_users"."status" IN (1, 3)
    AND ("import_source_users"."source_name" ILIKE '%Adr%'
        OR "import_source_users"."source_username" ILIKE '%Adr%')
ORDER BY
    "import_source_users"."status" ASC,
    "import_source_users"."id" DESC
LIMIT 101

Query plan: https://explain.depesz.com/s/lHUx

Edited by Rodrigo Tomonari

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Ghost User
    Ghost User @ghost1 ·
    Contributor
    2 Messages
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Category Reviewer Maintainer
    backend @ivaneG profile link current availability (UTC+1, 4 hours ahead of author) @ahuntsman profile link current availability (UTC-5, 2 hours behind author)
    database @igor.drozdov profile link current availability (UTC+2, 5 hours ahead of author) @ahegyi profile link current availability (UTC+2, 5 hours ahead of author)
    groupauthorization Reviewer review is optional for groupauthorization @hmehra profile link current availability (UTC+10, 13 hours ahead of author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Rodrigo Tomonari mentioned in issue #457066 (closed)

    mentioned in issue #457066 (closed)

  • Rodrigo Tomonari added 422 commits

    added 422 commits

    Compare with previous version

  • Rodrigo Tomonari resolved all threads

    resolved all threads

  • Ghost User
    Ghost User @ghost1 ·
    Contributor

    Database migrations (on the main database)

    Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

    Migration Type Total runtime Result DB size change
    20240627142648 - AddIndexesToImportSourceUsers Regular 8.6 s :white_check_mark: +40.00 KiB
    Runtime Histogram for all migrations
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 2
    0.1 seconds - 1 second 3
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Migration: 20240627142648 - AddIndexesToImportSourceUsers

    • Type: Regular
    • Duration: 8.6 s
    • Database size change: +40.00 KiB
    Calls Total Time Max Time Mean Time Rows Query
    1 7.4 ms 7.4 ms 7.4 ms 0 
    CREATE INDEX CONCURRENTLY "index_import_source_users_source_name_trgm" ON "import_source_users" USING gin ("source_name" gin_trgm_ops)
    1 5.9 ms 5.9 ms 5.9 ms 0 
    CREATE INDEX CONCURRENTLY "index_import_source_users_on_namespace_id_and_status" ON "import_source_users" ("namespace_id", "status", "id")
    1 3.0 ms 3.0 ms 3.0 ms 0 
    CREATE INDEX CONCURRENTLY "index_import_source_users_source_username_trgm" ON "import_source_users" USING gin ("source_username" gin_trgm_ops)
    2 0.0 ms 0.0 ms 0.0 ms 2 
    SELECT pg_backend_pid()
    Histogram for AddIndexesToImportSourceUsers
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 2
    0.1 seconds - 1 second 3
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Background Migration: BackfillPackagesDebianProjectArchitecturesProjectId

    Sampled 1 batches. Estimated Time to complete: 0 seconds
    • Interval: 120s
    • Total tuple count: 2
    • Max batch size: 0
    • Estimated seconds to complete: 0s
    • Estimated number of batches: 0
    • Average batch time: 2.14s
    • Batch size: 1000
    • N. of batches sampled: 1
    • N. of failed batches: 0

    Time estimation is conservative and based on sampling production data in a test environment. It represents the max time that migration could take. The actual time may differ from this estimation.

    _Consider changing max_batch_size and interval if this estimate is unacceptable._

    Calls Total Time Max Time Mean Time Rows Query
    1 15.3 ms 15.3 ms 15.3 ms 2 
    UPDATE packages_debian_project_architectures
      SET project_id = packages_debian_project_distributions.project_id
      FROM packages_debian_project_distributions
      WHERE packages_debian_project_distributions.id = packages_debian_project_architectures.distribution_id AND packages_debian_project_architectures.id IN (
        SELECT packages_debian_project_architectures.id
        FROM packages_debian_project_architectures
        WHERE packages_debian_project_architectures.id BETWEEN $1 AND $2 AND packages_debian_project_architectures.project_id IS NULL AND packages_debian_project_architectures.id >= $3
      )
    2 7.2 ms 7.0 ms 3.6 ms 2 
    INSERT INTO batched_background_migration_job_transition_logs (batched_background_migration_job_id, created_at, updated_at, previous_status, next_status) VALUES ($1, $2, $3, $4, $5) RETURNING id
    1 0.2 ms 0.2 ms 0.2 ms 1 
    UPDATE batched_background_migration_jobs
      SET updated_at = $1, started_at = $2, status = $3, attempts = $4
      WHERE batched_background_migration_jobs.id = $5
    1 0.1 ms 0.1 ms 0.1 ms 1 
    UPDATE batched_background_migration_jobs
      SET updated_at = $1, finished_at = $2, status = $3, metrics = $4
      WHERE batched_background_migration_jobs.id = $5
    2 0.1 ms 0.1 ms 0.0 ms 2 
    SELECT batched_background_migration_jobs.*
      FROM batched_background_migration_jobs
      WHERE batched_background_migration_jobs.id = $1
      LIMIT $2
    1 0.0 ms 0.0 ms 0.0 ms 1 
    SELECT batched_background_migrations.*
      FROM batched_background_migrations
      WHERE batched_background_migrations.id = $1
      LIMIT $2
    1 0.0 ms 0.0 ms 0.0 ms 1 
    SELECT sum(batched_background_migration_jobs.batch_size)
      FROM batched_background_migration_jobs
      WHERE batched_background_migration_jobs.batched_background_migration_id = $1 AND batched_background_migration_jobs.status IN ($2)
    1 0.0 ms 0.0 ms 0.0 ms 0 
    SELECT packages_debian_project_architectures.id
      FROM packages_debian_project_architectures
      WHERE packages_debian_project_architectures.id BETWEEN $1 AND $2 AND packages_debian_project_architectures.project_id IS NULL AND packages_debian_project_architectures.id >= $3
      ORDER BY packages_debian_project_architectures.id ASC
      LIMIT $4
      OFFSET $5
    1 0.0 ms 0.0 ms 0.0 ms 1 
    SELECT packages_debian_project_architectures.id
      FROM packages_debian_project_architectures
      WHERE packages_debian_project_architectures.id BETWEEN $1 AND $2 AND packages_debian_project_architectures.project_id IS NULL
      ORDER BY packages_debian_project_architectures.id ASC
      LIMIT $3
    Histogram of batch runtimes for BackfillPackagesDebianProjectArchitecturesProjectId
    Batch Runtime Count
    0 seconds - 10 seconds 1
    10 seconds - 1 minute 0
    1 minute - 2 minutes 0
    2 minutes - 3 minutes 0
    3 minutes - 5 minutes 0
    5 minutes + 0
    Histogram across all sampled batches of BackfillPackagesDebianProjectArchitecturesProjectId
    Query Runtime Count
    0 seconds - 0.1 seconds 7
    0.1 seconds - 0.5 seconds 4
    0.5 seconds - 1 second 0
    1 second - 2 seconds 0
    2 seconds - 5 seconds 0
    5 seconds + 0

    Other information

    Other migrations pending on GitLab.com
    Migration Type Total runtime Result DB size change
    20240627121919 - AddAutoCanceledByPartitionIdToCiPipelines Regular 5.0 s :white_check_mark: +0.00 B
    20240611121818 - RemoveProjectStatisticsPackagesSizeAndProjectIdIndex Post deploy 5.1 s :white_check_mark: +0.00 B
    20240627122810 - QueueQueueBackfillAutocancelPartitionIdOnCiPipelines Post deploy 4.1 s :white_check_mark: +0.00 B
    20240628133955 - IndexPackagesDebianProjectArchitecturesOnProjectId Post deploy 4.8 s :white_check_mark: +16.00 KiB
    20240628133956 - AddPackagesDebianProjectArchitecturesProjectIdFk Post deploy 5.2 s :warning: +0.00 B
    20240628133957 - AddPackagesDebianProjectArchitecturesProjectIdTrigger Post deploy 4.4 s :white_check_mark: +0.00 B
    20240628133958 - QueueBackfillPackagesDebianProjectArchitecturesProjectId Post deploy 5.2 s :white_check_mark: +0.00 B
    20240701083851 - RemovePartitionIdDefaultValueForCiSourcesProjects Post deploy 4.2 s :white_check_mark: +0.00 B
    Clone details
    Clone ID Clone Created At Clone Data Timestamp Expected Removal Time
    database-testing-3464871-14509543-main 2024-07-01T23:14:11Z 2024-07-01T20:09:57Z 2024-07-02 11:56:15 +0000
    database-testing-3464871-14509543-ci 2024-07-01T23:14:11Z 2024-07-01T20:44:56Z 2024-07-02 11:56:15 +0000

    Job artifacts

    Database migrations (on the ci database)

    Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

    Migration Type Total runtime Result DB size change
    20240627142648 - AddIndexesToImportSourceUsers Regular 10.6 s :white_check_mark: +40.00 KiB
    Runtime Histogram for all migrations
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 2
    0.1 seconds - 1 second 3
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Migration: 20240627142648 - AddIndexesToImportSourceUsers

    • Type: Regular
    • Duration: 10.6 s
    • Database size change: +40.00 KiB
    Calls Total Time Max Time Mean Time Rows Query
    1 13.2 ms 13.2 ms 13.2 ms 0 
    CREATE INDEX CONCURRENTLY "index_import_source_users_on_namespace_id_and_status" ON "import_source_users" ("namespace_id", "status", "id")
    1 6.3 ms 6.3 ms 6.3 ms 0 
    CREATE INDEX CONCURRENTLY "index_import_source_users_source_name_trgm" ON "import_source_users" USING gin ("source_name" gin_trgm_ops)
    1 3.9 ms 3.9 ms 3.9 ms 0 
    CREATE INDEX CONCURRENTLY "index_import_source_users_source_username_trgm" ON "import_source_users" USING gin ("source_username" gin_trgm_ops)
    2 0.0 ms 0.0 ms 0.0 ms 2 
    SELECT pg_backend_pid()
    Histogram for AddIndexesToImportSourceUsers
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 2
    0.1 seconds - 1 second 3
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Background Migration: QueueBackfillAutocancelPartitionIdOnCiPipelines

    Sampled 28 batches. Estimated Time to complete: 3 weeks, 1 day, 13 hours, and 22 minutes
    • Interval: 120s
    • Total tuple count: 1218086800
    • Max batch size: 0
    • Estimated seconds to complete: 1948920s
    • Estimated number of batches: 16241
    • Average batch time: 60.9s
    • Batch size: 75000
    • N. of batches sampled: 28
    • N. of failed batches: 0

    Time estimation is conservative and based on sampling production data in a test environment. It represents the max time that migration could take. The actual time may differ from this estimation.

    _Consider changing max_batch_size and interval if this estimate is unacceptable._

    Calls Total Time Max Time Mean Time Rows Query
    2770 786523.2 ms 1185.3 ms 283.9 ms 32995 
    UPDATE ci_pipelines
      SET auto_canceled_by_partition_id = canceling_pipelines.partition_id
      FROM ci_pipelines canceling_pipelines
      WHERE ci_pipelines.id BETWEEN $1 AND $2 AND ci_pipelines.id >= $3 AND ci_pipelines.id < $4 AND ci_pipelines.auto_canceled_by_id IS NOT NULL AND ci_pipelines.auto_canceled_by_id = canceling_pipelines.id
    28 6361.7 ms 534.9 ms 227.2 ms 264 
    UPDATE ci_pipelines
      SET auto_canceled_by_partition_id = canceling_pipelines.partition_id
      FROM ci_pipelines canceling_pipelines
      WHERE ci_pipelines.id BETWEEN $1 AND $2 AND ci_pipelines.id >= $3 AND ci_pipelines.auto_canceled_by_id IS NOT NULL AND ci_pipelines.auto_canceled_by_id = canceling_pipelines.id
    2798 3118.3 ms 40.5 ms 1.1 ms 2770 
    SELECT ci_pipelines.id
      FROM ci_pipelines
      WHERE ci_pipelines.id BETWEEN $1 AND $2 AND ci_pipelines.id >= $3
      ORDER BY ci_pipelines.id ASC
      LIMIT $4
      OFFSET $5
    28 6.9 ms 3.0 ms 0.2 ms 28 
    UPDATE batched_background_migration_jobs
      SET updated_at = $1, started_at = $2, status = $3, attempts = $4
      WHERE batched_background_migration_jobs.id = $5
    28 10.3 ms 1.3 ms 0.4 ms 28 
    UPDATE batched_background_migration_jobs
      SET updated_at = $1, finished_at = $2, status = $3, metrics = $4
      WHERE batched_background_migration_jobs.id = $5
    56 9.6 ms 0.8 ms 0.2 ms 56 
    INSERT INTO batched_background_migration_job_transition_logs (batched_background_migration_job_id, created_at, updated_at, previous_status, next_status) VALUES ($1, $2, $3, $4, $5) RETURNING id
    56 3.3 ms 0.1 ms 0.1 ms 56 
    SELECT batched_background_migration_jobs.*
      FROM batched_background_migration_jobs
      WHERE batched_background_migration_jobs.id = $1
      LIMIT $2
    28 1.4 ms 0.1 ms 0.1 ms 28 
    SELECT sum(batched_background_migration_jobs.batch_size)
      FROM batched_background_migration_jobs
      WHERE batched_background_migration_jobs.batched_background_migration_id = $1 AND batched_background_migration_jobs.status IN ($2)
    28 1.1 ms 0.1 ms 0.0 ms 28 
    SELECT ci_pipelines.id
      FROM ci_pipelines
      WHERE ci_pipelines.id BETWEEN $1 AND $2
      ORDER BY ci_pipelines.id ASC
      LIMIT $3
    28 1.0 ms 0.1 ms 0.0 ms 28 
    SELECT batched_background_migrations.*
      FROM batched_background_migrations
      WHERE batched_background_migrations.id = $1
      LIMIT $2
    Histogram of batch runtimes for QueueBackfillAutocancelPartitionIdOnCiPipelines
    Batch Runtime Count
    0 seconds - 10 seconds 0
    10 seconds - 1 minute 15
    1 minute - 2 minutes 13
    2 minutes - 3 minutes 0
    3 minutes - 5 minutes 0
    5 minutes + 0
    Histogram across all sampled batches of QueueBackfillAutocancelPartitionIdOnCiPipelines
    Query Runtime Count
    0 seconds - 0.1 seconds 83
    0.1 seconds - 0.5 seconds 5140
    0.5 seconds - 1 second 617
    1 second - 2 seconds 8
    2 seconds - 5 seconds 0
    5 seconds + 0

    Other information

    Other migrations pending on GitLab.com
    Migration Type Total runtime Result DB size change
    20240627121919 - AddAutoCanceledByPartitionIdToCiPipelines Regular 6.8 s :white_check_mark: +0.00 B
    20240611121818 - RemoveProjectStatisticsPackagesSizeAndProjectIdIndex Post deploy 7.3 s :white_check_mark: +0.00 B
    20240627122810 - QueueQueueBackfillAutocancelPartitionIdOnCiPipelines Post deploy 7.2 s :white_check_mark: +0.00 B
    20240628133955 - IndexPackagesDebianProjectArchitecturesOnProjectId Post deploy 6.9 s :white_check_mark: +8.00 KiB [note]
    20240628133956 - AddPackagesDebianProjectArchitecturesProjectIdFk Post deploy 7.1 s :white_check_mark: +0.00 B
    20240628133957 - AddPackagesDebianProjectArchitecturesProjectIdTrigger Post deploy 6.4 s :white_check_mark: +0.00 B
    20240628133958 - QueueBackfillPackagesDebianProjectArchitecturesProjectId Post deploy 6.1 s :white_check_mark: +0.00 B
    20240701083851 - RemovePartitionIdDefaultValueForCiSourcesProjects Post deploy 6.3 s :white_check_mark: +0.00 B
    Clone details
    Clone ID Clone Created At Clone Data Timestamp Expected Removal Time
    database-testing-3464871-14509543-main 2024-07-01T23:14:11Z 2024-07-01T20:09:57Z 2024-07-02 11:56:15 +0000
    database-testing-3464871-14509543-ci 2024-07-01T23:14:11Z 2024-07-01T20:44:56Z 2024-07-02 11:56:15 +0000

    Job artifacts

    Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic

    Edited by ****
  • **** added database-testing-automation label

    added database-testing-automation label

  • Justin Ho Tuan Duong mentioned in merge request !158026 (merged)

    mentioned in merge request !158026 (merged)

  • Rodrigo Tomonari changed the description

    changed the description

  • Rodrigo Tomonari added 1 commit

    added 1 commit

    Compare with previous version

  • Rodrigo Tomonari changed the description

    changed the description

  • Rodrigo Tomonari added 1 commit

    added 1 commit

    • 74b50a5d - Remove comments from migration

    Compare with previous version

  • Rodrigo Tomonari marked this merge request as ready

    marked this merge request as ready

  • Rodrigo Tomonari requested review from @.luke

    requested review from @.luke

  • Luke Duncalfe
  • Luke Duncalfe approved this merge request

    approved this merge request

  • 🤖 GitLab Bot 🤖 added pipeline:mr-approved label

    added pipeline:mr-approved label

  • 🤖 GitLab Bot 🤖 added pipelinetier-2 label and removed pipelinetier-1 label

    added pipelinetier-2 label and removed pipelinetier-1 label

    • 🤖 GitLab Bot 🤖
      🤖 GitLab Bot 🤖 @gitlab-bot ·
      Maintainer
      Resolved by Terri Chu

      Before you set this MR to auto-merge

      This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

      Before you resolve this discussion, please check the following:

      • You are the last maintainer of this merge request
      • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
      • This pipeline is recent enough (created in the last 8 hours)

      If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.

      See pipeline tiers and merging a merge request for more details.

  • Luke Duncalfe requested review from @terrichu and removed review request for @.luke

    requested review from @terrichu and removed review request for @.luke

  • Ghost User
    Ghost User @ghost1 ·
    Contributor

    :tools: Generated by gitlab_quality-test_tooling.

    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #7282910220 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 65.65 s < 50.13 s
    #7282910175 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.1 s < 50.13 s
    #7282910261 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.76 s < 50.13 s
    #7328940326 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.4 s < 50.13 s
    #7328940408 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.3 s < 50.13 s
    #7328940533 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 67.13 s < 50.13 s
    #7329113010 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 65.87 s < 50.13 s
    #7329112768 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 67.1 s < 50.13 s
    #7329112872 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.33 s < 50.13 s
    #7337942136 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 65.52 s < 50.13 s
    #7337942100 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.51 s < 50.13 s
    #7337942060 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.58 s < 50.13 s
    #7344195585 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.12 s < 50.13 s
    #7344195677 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 67.13 s < 50.13 s
    #7344195511 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 67.01 s < 50.13 s
    #7354645021 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.05 s < 50.13 s
    #7354645220 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.35 s < 50.13 s
    #7354645108 spec/features/admin/users/users_spec.rb#L177 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 67.4 s < 50.13 s
  • A deleted user added rspec:slow test detected label

    added rspec:slow test detected label

  • Ghost User
    Ghost User @ghost1 ·
    Contributor

    E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 432923d2

    expand test summary 
    +------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Verify      | 43     | 0      | 4       | 0     | 47    | ✅     |
| Create      | 128    | 0      | 12      | 0     | 140   | ✅     |
| Plan        | 67     | 0      | 2       | 0     | 69    | ✅     |
| Govern      | 68     | 0      | 0       | 0     | 68    | ✅     |
| Data Stores | 27     | 0      | 4       | 0     | 31    | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Package     | 19     | 0      | 12      | 0     | 31    | ✅     |
| Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 368    | 0      | 35      | 0     | 403   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for 432923d2

    expand test summary 
    +-------------------------------------------------------------+
|                       suites summary                        |
+--------+--------+--------+---------+-------+-------+--------+
|        | passed | failed | skipped | flaky | total | result |
+--------+--------+--------+---------+-------+-------+--------+
| Create | 278    | 0      | 32      | 40    | 310   | ✅     |
| Manage | 30     | 0      | 15      | 2     | 45    | ✅     |
| Govern | 4      | 0      | 0       | 0     | 4     | ✅     |
| Plan   | 8      | 0      | 0       | 0     | 8     | ✅     |
+--------+--------+--------+---------+-------+-------+--------+
| Total  | 320    | 0      | 47      | 42    | 367   | ✅     |
+--------+--------+--------+---------+-------+-------+--------+
  • Rodrigo Tomonari requested review from @alexpooley

    requested review from @alexpooley

  • Terri Chu requested review from @eread

    requested review from @eread

  • Terri Chu mentioned in issue gitlab-org/database-team/team-tasks#400

    mentioned in issue gitlab-org/database-team/team-tasks#400

  • Terri Chu
  • Terri Chu approved this merge request

    approved this merge request

  • Terri Chu removed review request for @terrichu

    removed review request for @terrichu

  • Evan Read approved this merge request

    approved this merge request

  • 🤖 GitLab Bot 🤖
    🤖 GitLab Bot 🤖 @gitlab-bot ·
    Maintainer

    Hi @eread :wave:,

    GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.

    This message was generated automatically. You're welcome to improve it.

  • 🤖 GitLab Bot 🤖 added Technical Writing label

    added Technical Writing label

  • Evan Read added docsfeature label

    added docsfeature label

  • Evan Read removed review request for @eread

    removed review request for @eread

  • Alex Pooley
  • Alex Pooley approved this merge request

    approved this merge request

  • Alex Pooley added databasereviewed label and removed databasereview pending label

    added databasereviewed label and removed databasereview pending label

  • Alex Pooley requested review from @krasio and removed review request for @alexpooley

    requested review from @krasio and removed review request for @alexpooley

  • Rodrigo Tomonari requested review from @alexbuijs

    requested review from @alexbuijs

  • Alex Buijs approved this merge request

    approved this merge request

  • Alex Buijs removed review request for @alexbuijs

    removed review request for @alexbuijs

  • Krasimir Angelov
  • Rodrigo Tomonari added 1 commit

    added 1 commit

    Compare with previous version

  • Rodrigo Tomonari reset approvals from @.luke, @alexpooley, and @terrichu by pushing to the branch

    reset approvals from @.luke, @alexpooley, and @terrichu by pushing to the branch

  • Martin Wortschack mentioned in issue #461529 (closed)

    mentioned in issue #461529 (closed)

  • A deleted user added Data WarehouseImpact Check label

    added Data WarehouseImpact Check label

  • Rodrigo Tomonari added 2239 commits

    added 2239 commits

    Compare with previous version

    Toggle commit list
  • Rodrigo Tomonari reset approvals from @eread and @alexbuijs by pushing to the branch

    reset approvals from @eread and @alexbuijs by pushing to the branch

  • Rodrigo Tomonari requested review from @krasio

    requested review from @krasio

  • Rodrigo Tomonari changed milestone to %17.3

    changed milestone to %17.3

  • Rodrigo Tomonari added 1 commit

    added 1 commit

    Compare with previous version

  • Krasimir Angelov
  • Rodrigo Tomonari added 1 commit

    added 1 commit

    • 432923d2 - Change index order and remove :id from index

    Compare with previous version

  • Rodrigo Tomonari requested review from @krasio

    requested review from @krasio

  • Krasimir Angelov approved this merge request

    approved this merge request

  • Krasimir Angelov added databaseapproved label and removed databasereviewed label

    added databaseapproved label and removed databasereviewed label

  • Radovan Bacovic added Data WarehouseNot Impacted label and removed Data WarehouseImpact Check label

    added Data WarehouseNot Impacted label and removed Data WarehouseImpact Check label

  • Alex Buijs approved this merge request

    approved this merge request

  • 🤖 GitLab Bot 🤖 added pipelinetier-3 label and removed pipelinetier-2 label

    added pipelinetier-3 label and removed pipelinetier-2 label

  • Terri Chu requested review from @terrichu

    requested review from @terrichu

  • Terri Chu approved this merge request

    approved this merge request

  • Terri Chu enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Terri Chu resolved all threads

    resolved all threads

  • Terri Chu started a merge train

    started a merge train

  • Terri Chu merged

    merged

  • 🤖 GitLab Bot 🤖
    🤖 GitLab Bot 🤖 @gitlab-bot ·
    Maintainer

    Hello @rodrigo.tomonari :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • GitLab Release Tools Bot added workflowstaging-canary label

    added workflowstaging-canary label

  • GitLab Release Tools Bot added workflowcanary label and removed workflowstaging-canary label

    added workflowcanary label and removed workflowstaging-canary label

  • GitLab Release Tools Bot added workflowstaging label and removed workflowcanary label

    added workflowstaging label and removed workflowcanary label

  • GitLab Release Tools Bot added workflowproduction label and removed workflowstaging label

    added workflowproduction label and removed workflowstaging label

  • GitLab Release Tools Bot added workflowpost-deploy-db-production label and removed workflowproduction label

    added workflowpost-deploy-db-production label and removed workflowproduction label

  • GitLab Release Tools Bot added releasedcandidate label

    added releasedcandidate label

  • GitLab Release Tools Bot added releasedpublished label and removed releasedcandidate label

    added releasedpublished label and removed releasedcandidate label

  • Kubitus Bot mentioned in merge request kubitus-project/kubitus-installer!3241 (merged)

    mentioned in merge request kubitus-project/kubitus-installer!3241 (merged)

  • Martin Wortschack added User Contribution Mapping label

    added User Contribution Mapping label

  • Terri Chu mentioned in merge request gitlab-com/www-gitlab-com!137049 (merged)

    mentioned in merge request gitlab-com/www-gitlab-com!137049 (merged)

    • Please register or sign in to reply