Skip to content

Increase specificity of padding on CI Icon badge

Scott de Jonge requested to merge sdejonge-badge-bugfix into master

What does this MR do and why?

gitlab-ui!3307 (merged) introduces gl-py-0 on .gl-button .gl-badge styles which conflicts with the gl-p-2 class used in <ci-icon>. Add ! important to class to override specificity of the selector from gitlab-ui styles as an interum fix while more robust solution can be resolved in gitlab-ui and updated here.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
gitlab.com_gitlab-org_gitlab_-_merge_requests_155959_pipelines gitlab.com_gitlab-org_gitlab_-merge_requests_155959_pipelines__1

How to set up and validate locally

  1. View any usage of <ci-icon> e.g. pipelines
  2. Ensure padding is equal on all sides

Merge request reports