Fix rubocop todos in search_results_spec.rb

What does this MR do and why?

Related to #461874

I pulled a bunch of Rubocop todo fixes (which failed the pipeline) out of !155516 to make that MR smaller

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

Relying upon pipelines.

If you want to run the spec locally you'll need to enable elasticsearch in gdk first