Skip to content

Refactor migration obsolete keep

Terri Chu requested to merge tchu-adjust-branch-name-for-keep into master

What does this MR do and why?

This MR refactors the MarkOldAdvancedSearchMigrationsAsObsolete keep

  • Reduce branch name length
  • Refactor description and make the link more clear
  • assign MRs evenly to team members

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

patch 
diff --git a/keeps/mark_old_advanced_search_migrations_as_obsolete.rb b/keeps/mark_old_advanced_search_migrations_as_obsolete.rb
index e2c613228365..d6ba6ed5bad8 100644
--- a/keeps/mark_old_advanced_search_migrations_as_obsolete.rb
+++ b/keeps/mark_old_advanced_search_migrations_as_obsolete.rb
@@ -42,6 +42,7 @@ def each_change
         next unless mark_obsolete_change
 
         search_team_map[mark_obsolete_change.assignees.first] += 1
+        puts search_team_map
         yield(mark_obsolete_change)
       end

  1. apply patch above

  2. run dry run of housekeeper keep

bundle exec gitlab-housekeeper --target-branch=master -k Keeps::MarkOldAdvancedSearchMigrationsAsObsolete -m 10 --dry-run
  1. verify team members are assigned evenly
Edited by Terri Chu

Merge request reports