Remove "+" icon and add word "new" to button
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
What does this MR do and why?
This MR removes the "+" icon and adds the word "new" to the "Add rule" and "Add condition" button
Related to issue: #464710 (closed)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Visit
/-/security/policies/new?type=scan_execution_policy
and you should seeAdd new condition
- Visit
/-/security/policies/new?type=approval_policy
and you should seeAdd new rule
Related to #464710 (closed)
Merge request reports
Activity
added devopsgovern groupsecurity policies sectionsec typebug labels
added Leading Organization label
added pipelinetier-1 label
added Category:Security Policy Management label
Thanks for your contribution to GitLab @jzeng88!
- If you need help, comment @gitlab-bot help or come say hi on Discord.
- When you're ready for a review, comment on this merge request with @gitlab-bot ready.
- We welcome AI-generated contributions! Read more/check the box at the top of the merge request description.
- To add labels to your merge request, comment @gitlab-bot label ~"label1" ~"label2".
This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @jzeng88
added linked-issue label
4 Warnings This merge request does not refer to an existing milestone. This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Labels missing: please ask a reviewer or maintainer to add frontend to this merge request. testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/security_orchestration/components/policy_editor/scan_execution/editor_component.vue
- <gl-button variant="link" data-testid="add-rule" icon="plus" @click="addRule"> + <gl-button variant="link" data-testid="add-rule" @click="addRule">
ee/app/assets/javascripts/security_orchestration/components/policy_editor/scan_result/editor_component.vue
- <gl-button variant="link" data-testid="add-rule" icon="plus" @click="addRule"> + <gl-button variant="link" data-testid="add-rule" @click="addRule">
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @fernando-c
(UTC-5)
@f_caplette
(UTC-4)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@gitlab-bot ready @fernando-c
added workflowready for review label and removed workflowin dev label
requested review from @fernando-c
@fernando-c, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
mentioned in issue #464710 (closed)
added pipeline:mr-approved label