Skip to content

Draft: Set RUBY_VERSION in QA job for release environments

Dat Tang requested to merge dattang/do-not-inherit-variables-in-re-qa-job into master

What does this MR do and why?

Due to a change in quality/pipeline-common (see gitlab-org/quality/pipeline-common!428 (diffs)), RUBY_VERSION now need to be a patch version instead of a minor version. Meanwhile, the RUBY_VERSION provided by the GitLab pipeline is a minor version. Thus, this change set RUBY_VERSION to the QA job.

Note that, it is not possible to stop inheriting the variable from the upstream, because other jobs may still use it.

Ref: gitlab-com/gl-infra/delivery#20328 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Testing

I tested this change in a simple pipeline https://gitlab.com/dat.tang.gitlab/test-gitlab-ci/-/blob/f8018512b0fc86afe92efa5814353de7a97cfa26/.gitlab-ci.yml, where you can see that the image was set correctly https://gitlab.com/dat.tang.gitlab/test-gitlab-ci/-/jobs/7175338333#L5.

Edited by Dat Tang

Merge request reports