Skip to content

Refactor empty search results

Terri Chu requested to merge 461874-refactor-empty-search-results into master

What does this MR do and why?

Related to #461874 (closed)

Refactor Gitlab::EmptySearchResults so that I can use it in the next MR !157210 (merged)

  • Move to search namespace
  • Clean up rubocop todos
  • Introduce scope to failed? method so that it can be used with all Advanced search scopes. Currently this works for Zoekt only but this code can (and will) be used by Advanced search

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No UI changes

How to set up and validate locally

  1. Enable exact code search for gdk
  2. run a code search and verify that exact code search is working
  3. stop the zoekt webserver
 gdk stop zoekt-webserver-development
  1. run a code search and verify the failed UI comes back

image

Edited by Terri Chu

Merge request reports