Skip to content

Fix undefined method error for invalid ref

Vasilii Iakliushin requested to merge 468695_fix_500_error into master

What does this MR do and why?

Contributes to #468695 (closed)

Problem

Refactoring from !155245 (merged) introduced a change to the execution flow.

Solution

  • Restore the previous flow
  • Add a test to check for this error

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-06-24_at_15.56.49 Screenshot_2024-06-24_at_15.56.11

How to set up and validate locally

  1. Visit link like: http://gdk.test:3000/gitlab-org/gitlab-test/-/blame/%0A
  2. You should see 404 page after the fix
Edited by Vasilii Iakliushin

Merge request reports