Skip to content

Enable AssignResourceFromResourceGroupWorkerV2 by default

Pam Artiaga requested to merge 460793-enable-assign-worker-v2-by-default into master

What does this MR do and why?

As part of the fix for CI Jobs with resource group get stuck "waiting ... (#436988 - closed), the AssignResourceFromResourceGroupWorker was copied to AssignResourceFromResourceGroupWorkerV2 with the deduplication strategy changed to until_executing (see MR: !152303 (merged)). This change has been enabled globally and verified in production (see #436988 (comment 1934506030) and #460793 (comment 1935376669)).

This MR enables by default the feature flag that toggles the change: assign_resource_worker_deduplicate_until_executing. The feature flag is already enabled globally on Gitlab.com. Expectations are detailed in this section of the feature flag rollout issue.

Considerations

  • this is enabled by default instead of fully released in order to allow ensure that V1 jobs in the queue are fully drained before the worker is deleted.
  • gitlab_com_derisk types cannot be enabled by default, so I changed the type to beta.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #460793

Merge request reports