Skip to content

Revert "Merge branch '430915-enhance-permission-selector' into 'master'"

What does this MR do and why?

  • This reverts merge request !151663 (merged)
  • Resolves #468264 (closed)
  • Because available_from_access_level hasn't been populated for all custom abilities, this commit is resulting in unexpected user behaviour. If the base access level is Owner, they should have most of the custom abilities selected, but currently only a few get pre-selected.
  • Secondly, the pre-selected permissions don't appear in the Custom permissions column in the table after they are created (see before video). The groupauthorization needs to discuss more how we want to handle pre-selected permissions before we can introduce them, since permissions also differ between groups and projects. For example, a maintainer already has access to manage_merge_request_settings in a project, but only an owner has access to it in a group.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screen_Recording_2024-06-20_at_12.41.16_PM Screen_Recording_2024-06-24_at_3.44.15_PM

How to set up and validate locally

  1. Log-in as admin and navigate to /admin/application_settings/roles_and_permissions/
  2. Select Owner as the base access level and Manage merge request settings as the custom permission. Click on Create role
Edited by Hinam Mehra

Merge request reports

Loading