Skip to content

Move Result class to Platform bounded context

Chad Woolley requested to merge caw-rd-move-result-to-platform-bounded-context into master

Issue: Move the lib/result ROP class to the Platform b... (#467293)

What does this MR do and why?

Moves the Result class to the Gitlab::Fp namespace, which is in the Platform bounded context.

This resolves the following rubocop errors:

  • Gitlab/NamespacedClass
  • Gitlab/BoundedContexts

This move also provides the following benefits:

  • Makes the Functional and Railway Oriented Programming patterns used in the Remote Development Workspaces domain more reusable and accessible to other parts of the monolith. See lib/gitlab/fp/README.md (updated in this MR) for more context.
  • Eliminates possible confusion/conflict with other result.rb classes which exist in the monolith.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports