Skip to content

Refactor params use to resolve some StrongParams RuboCop exceptions

Nick Malcolm requested to merge 468594-rubocop-pagination-refactor into master

What does this MR do and why?

Refactor params use to resolve some StrongParams RuboCop exceptions

In !156108 (comment 1952833169) we decided to reduce the scope of the MR so that fewer files were changed.

There are 17 StrongParams Rubocop Rule exceptions where updating to pagination_params will resolve the exception for that file. This commit addresses those.

There are still many other unresolved exceptions, including where pagination_params can be used. But leaving those for another MR keeps the changeset smaller and more easily reviewable.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #468594 (closed)

Edited by Nick Malcolm

Merge request reports