Skip to content

Remove BOT_USER_ID from e2e:fulfillment-quarantine-report

Valerie Burton requested to merge remove-bot-user-id-from-e2e-fulfillment-quarantine-report into master

What does this MR do and why?

When a new project access token is generated, a new corresponding bot user is generated as well. Because of this, if the PROJECT_TOKEN_FOR_CI_SCRIPTS_API_USAGE token is rotated in the future, the e2e:fulfillment-quarantine-report script will begin adding multiple comments to MRs since the BOT_USER_ID will no longer be valid, and the script will be unable to detect any previous existing comments.

This was recently seen in CustomersDot in the MR https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/10263

This MR removes checking for the BOT_USER_ID and simplifies the script to only check for a comment with the same comment header, so that we can prevent issues such as this in the future when rotating the project token. Please see https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/10285 for the same fix applied to the CustomersDot project.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports