Skip to content

Remove unused template data in package registry

What does this MR do and why?

The code changes remove the resourceId property from the data passed to the Vue component js-vue-packages-list. This component is responsible for displaying a list of packages.

The resourceId property was previously used to identify the resource (group or project) for which the packages were being displayed.

However, it seems that this property is no longer needed, as the fullPath property can be used to uniquely identify the resource.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No change in UI.

How to set up and validate locally

List & Details

  1. rails c - Open the rails console

  2. p = Project.find(1) - Find one of your GDK projects. Project id can be found on the project home page

  3. FactoryBot.create_list(:npm_package, 10, project: p, name: p.name) - Creates 10 npm packages

  4. Add this line if above fails during the creation

     def fixture_file_upload(*args, **kwargs)
       Rack::Test::UploadedFile.new(*args, **kwargs)
     end
  5. Visit groups & projects package list page.

  6. visit package registry detail page Other versions tab via groups & projects package list page

  7. Confirm that packages can be deleted as well.

Edited by Rahul Chanila

Merge request reports